Skip to content

MINOR: Document ordering contract of iterator for window stores and session stores#2751

Closed
miguno wants to merge 1 commit intoapache:trunkfrom
miguno:trunk-streams-window-iterator-doc-fixes
Closed

MINOR: Document ordering contract of iterator for window stores and session stores#2751
miguno wants to merge 1 commit intoapache:trunkfrom
miguno:trunk-streams-window-iterator-doc-fixes

Conversation

@miguno
Copy link
Copy Markdown
Contributor

@miguno miguno commented Mar 28, 2017

No description provided.

@miguno miguno changed the title Document ordering contract of iterator for window stores and session stores MINOR: Document ordering contract of iterator for window stores and session stores Mar 28, 2017
@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Mar 28, 2017

Please review any of @guozhangwang @enothereska @dguy @mjsax.

This PR is a follow-up on an offline conversation I had with @dguy.

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2452/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2448/
Test PASSed (JDK 7 and Scala 2.10).

dguy
dguy approved these changes Mar 28, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miguno LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 28, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2448/
Test FAILed (JDK 8 and Scala 2.12).

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Mar 30, 2017

retest this please.

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2561/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2557/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2557/
Test PASSed (JDK 8 and Scala 2.12).

ijuma
ijuma approved these changes Apr 11, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM. Merging to trunk and 0.10.2.

@asfgit asfgit closed this in 7c58351 Apr 11, 2017
asfgit pushed a commit that referenced this pull request Apr 11, 2017
@ijuma
MINOR: Document ordering contract of iterator for window stores and s…
2adaa50 
…ession stores

Author: Michael G. Noll <michael@confluent.io>

Reviewers: Damian Guy <damian.guy@gmail.com>, Ismael Juma <ismael@juma.me.uk>

Closes #2751 from miguno/trunk-streams-window-iterator-doc-fixes

(cherry picked from commit 7c58351)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@miguno miguno deleted the trunk-streams-window-iterator-doc-fixes branch April 12, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

@dguy dguy dguy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miguno @asfbot @guozhangwang @ijuma @dguy