Skip to content

KAFKA-5003: StreamThread should catch InvalidTopicException#2774

Closed
mjsax wants to merge 4 commits intoapache:0.10.2from
mjsax:minor-fix-reset-0102
Closed

KAFKA-5003: StreamThread should catch InvalidTopicException#2774
mjsax wants to merge 4 commits intoapache:0.10.2from
mjsax:minor-fix-reset-0102

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Mar 31, 2017

No description provided.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 31, 2017

Same as #2747 but for 0.10.2

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2565/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2569/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2565/
Test PASSed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 31, 2017

Updated. cf #2747 (comment)

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2591/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2595/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 31, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2591/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax mjsax force-pushed the minor-fix-reset-0102 branch from ef708d2 to 092b8ec Compare April 2, 2017 00:25
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2615/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2611/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2611/
Test PASSed (JDK 8 and Scala 2.12).

@mjsax mjsax changed the title MINOR: StreamThread should catch InvalidTopicException KAFKA-5003: StreamThread should catch InvalidTopicException Apr 3, 2017
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2639/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2643/
Test FAILed (JDK 8 and Scala 2.11).

@mjsax mjsax force-pushed the minor-fix-reset-0102 branch from 8e231c7 to 6daa9a9 Compare April 3, 2017 16:33
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2639/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax mjsax force-pushed the minor-fix-reset-0102 branch from 6929a4e to c74efb7 Compare April 3, 2017 16:37
@mjsax mjsax mentioned this pull request Apr 3, 2017
Closed
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2647/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2643/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2643/
Test PASSed (JDK 8 and Scala 2.12).

@enothereska
Copy link
Copy Markdown
Contributor

enothereska commented Apr 6, 2017

@mjsax there are some differences in the test from trunk. E.g., there is no method shouldOnlyReadForEarliest here while it exists in trunk. Could you summarize in 1-2 sentences? Thanks.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 6, 2017

This is just missing the latest update to the trunk PR, which I just merged. Once @mjsax updates this PR, I'll merge it.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Apr 6, 2017

@ijuma Cherry-picked the new test from trunk.

ijuma
ijuma approved these changes Apr 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after Jenkins completes.

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2790/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2786/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2786/
Test PASSed (JDK 8 and Scala 2.12).

asfgit pushed a commit that referenced this pull request Apr 6, 2017
@mjsax @ijuma
KAFKA-5003; StreamThread should catch InvalidTopicException
0950994 
Author: Matthias J. Sax <matthias@confluent.io>

Reviewers: Eno Thereska <eno@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #2774 from mjsax/minor-fix-reset-0102
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 6, 2017

Merged to 0.10.2. Can you please close the PR?

@mjsax mjsax closed this Apr 6, 2017
@mjsax mjsax deleted the minor-fix-reset-0102 branch April 7, 2017 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mjsax @asfbot @enothereska @ijuma