Skip to content

KAFKA-4901: Make ProduceRequest thread-safe#2810

Closed
ijuma wants to merge 1 commit intoapache:0.10.2from
ijuma:kafka-4901-produce-request-thread-safety-0-10-2
Closed

KAFKA-4901: Make ProduceRequest thread-safe#2810
ijuma wants to merge 1 commit intoapache:0.10.2from
ijuma:kafka-4901-produce-request-thread-safety-0-10-2

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Apr 5, 2017

A more conservative version of the change for the 0.10.2
branch.

Trunk commit: 1659ca1.

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2734/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2734/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2738/
Test FAILed (JDK 8 and Scala 2.11).

@ijuma ijuma force-pushed the kafka-4901-produce-request-thread-safety-0-10-2 branch from 91b0aa3 to 47cf02d Compare April 5, 2017 09:40
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2739/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2735/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2735/
Test FAILed (JDK 7 and Scala 2.10).

A more conservative version of the change for the 0.10.2
branch.
@ijuma ijuma force-pushed the kafka-4901-produce-request-thread-safety-0-10-2 branch from 47cf02d to b2045f4 Compare April 5, 2017 09:56
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2736/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2740/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2736/
Test FAILed (JDK 8 and Scala 2.12).

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Apr 5, 2017

retest this please

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2747/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2743/
Test FAILed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2743/
Test PASSed (JDK 8 and Scala 2.12).

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Apr 5, 2017

The tests that failed are known transient failures that have been fixed in trunk.

@junrao
Copy link
Copy Markdown
Contributor

junrao commented Apr 6, 2017

@ijuma : Thanks for the patch. LGTM. I will let you merge it into 0.10.2.

asfgit pushed a commit that referenced this pull request Apr 6, 2017
A more conservative version of the change for the 0.10.2
branch.

Trunk commit: 1659ca1.

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #2810 from ijuma/kafka-4901-produce-request-thread-safety-0-10-2
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Apr 6, 2017

Thanks, merged to 0.10.2.

@ijuma ijuma closed this Apr 6, 2017
@ijuma ijuma deleted the kafka-4901-produce-request-thread-safety-0-10-2 branch September 5, 2017 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants