MINOR: update javadoc on ReadOnlyWindowStore#2811
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
@ijuma Can you cherry-pick this to |
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM with some minor changes. If you're OK with them, I'll make them during the merge.
| * +-------------------------------- | ||
| * </pre> | ||
| * And we called {@code store.fetch("A", 10, 20)} then the results will contain the first | ||
| * three windows from the table above, i.e., all those were start time >= 10 and <= 20. |
There was a problem hiding this comment.
Minor typo, were -> where? Also, 10 <= start time <= 20 might be slightly better notation.
| * | A | 25 | 35 | | ||
| * +-------------------------------- | ||
| * </pre> | ||
| * And we called {@code store.fetch("A", 10, 20)} then the results will contain the first |
|
Refer to this link for build results (access rights to CI server needed): |
|
Merged to trunk and 0.10.2. |
Highlight that the range in `fetch` is inclusive of both `timeFrom` and `timeTo` Author: Damian Guy <damian.guy@gmail.com> Reviewers: Michael G. Noll <michael@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes #2811 from dguy/minor-window-fetch-java-doc (cherry picked from commit b611cfa) Signed-off-by: Ismael Juma <ismael@juma.me.uk>
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
Highlight that the range in
fetchis inclusive of bothtimeFromandtimeTo