Skip to content

MINOR: Improve topic management instructions for Kafka Streams examples#2812

Closed
miguno wants to merge 1 commit intoapache:trunkfrom
miguno:trunk-streams-examples-docs
Closed

MINOR: Improve topic management instructions for Kafka Streams examples#2812
miguno wants to merge 1 commit intoapache:trunkfrom
miguno:trunk-streams-examples-docs

Conversation

@miguno
Copy link
Copy Markdown
Contributor

@miguno miguno commented Apr 5, 2017

No description provided.

@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Apr 5, 2017

Please review any of @enothereska @guozhangwang @mjsax, with Cc: to @ijuma

@miguno miguno changed the title Improve topic management instructions for Kafka Streams examples MINOR: Improve topic management instructions for Kafka Streams examples Apr 5, 2017
@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2742/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2742/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2746/
Test PASSed (JDK 8 and Scala 2.11).

mjsax
mjsax approved these changes Apr 5, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enothereska
Copy link
Copy Markdown
Contributor

enothereska commented Apr 6, 2017

LGTM

ijuma
ijuma approved these changes Apr 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 6, 2017

Is this just for trunk or also 0.10.2?

@asfgit asfgit closed this in 6ba98f6 Apr 6, 2017
asfgit pushed a commit that referenced this pull request Apr 6, 2017
@ijuma
MINOR: Improve topic management instructions for Kafka Streams examples
8e35721 
Author: Michael G. Noll <michael@confluent.io>

Reviewers: Matthias J. Sax <matthias@confluent.io>, Eno Thereska <eno@confluent.io>, Ismael Juma <ismael@juma.me.uk>

Closes #2812 from miguno/trunk-streams-examples-docs

(cherry picked from commit 6ba98f6)
Signed-off-by: Ismael Juma <ismael@juma.me.uk>
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 6, 2017

Merged to trunk and 0.10.2 since it merged cleanly and it's just doc updates.

@miguno
Copy link
Copy Markdown
Contributor Author

miguno commented Apr 6, 2017

Thanks @ijuma. Yes, it should go (have gone) into trunk and 0.10.2 -- just what you did. :-)

@miguno miguno deleted the trunk-streams-examples-docs branch February 9, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

@mjsax mjsax mjsax approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miguno @asfbot @enothereska @ijuma @mjsax