Skip to content

MINOR: Improve log4j on stream thread and stream process#2817

Closed
enothereska wants to merge 1 commit intoapache:0.10.2from
enothereska:KMinor-improve-log4j-0.10.2
Closed

MINOR: Improve log4j on stream thread and stream process#2817
enothereska wants to merge 1 commit intoapache:0.10.2from
enothereska:KMinor-improve-log4j-0.10.2

Conversation

@enothereska
Copy link
Copy Markdown
Contributor

@enothereska enothereska commented Apr 6, 2017

Cherry pick from #2685

@enothereska
Copy link
Copy Markdown
Contributor Author

enothereska commented Apr 6, 2017

@ijuma or @ewencp or @gwenshap could you have a look? Thanks.

ijuma
ijuma approved these changes Apr 6, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/2786/
Test FAILed (JDK 8 and Scala 2.11).

@enothereska
Copy link
Copy Markdown
Contributor Author

enothereska commented Apr 6, 2017

kafka.server.SaslSslReplicaFetchTest.testReplicaFetcherThread failed, not related to PR

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/2782/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2782/
Test PASSed (JDK 8 and Scala 2.12).

asfgit pushed a commit that referenced this pull request Apr 6, 2017
@enothereska @ijuma
MINOR: Improve log4j on stream thread and stream process
2dfeff0 
Cherry pick from #2685

Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>

Closes #2817 from enothereska/KMinor-improve-log4j-0.10.2
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Apr 6, 2017

Merged to 0.10.2, please close the PR.

@enothereska enothereska closed this Apr 6, 2017
@enothereska enothereska deleted the KMinor-improve-log4j-0.10.2 branch April 6, 2017 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enothereska @asfbot @ijuma