KAFKA-2622: Add Time logical type for Copycat.#285
Closed
ewencp wants to merge 2 commits intoapache:trunkfrom
Closed
KAFKA-2622: Add Time logical type for Copycat.#285ewencp wants to merge 2 commits intoapache:trunkfrom
ewencp wants to merge 2 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
@guozhangwang Quick follow up to the logical types patch. I realized we can't avoid adding a Time type for now since we need it for SQL types in the JDBC connector. Should be a quick review since this is basically the same as the Date type, just zeroing out the date fields instead of the time fields. |
Contributor
Author
|
Actually, hold off on review. I realized there's an issue with validating values when you use Struct.put() that I still need to resolve. |
Contributor
Author
|
Ok, updated to handle logical types in validation, which is really only happening in Struct.put() for now. Should really be ready for review now, @guozhangwang |
Contributor
|
LGTM. |
Contributor
There was a problem hiding this comment.
Is the claim in the exception correct? We should have have non-zero values for some fields.
Contributor
There was a problem hiding this comment.
Right. It should be "any date field"
gardnervickers
pushed a commit
to gardnervickers/kafka-1
that referenced
this pull request
Feb 4, 2021
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…on (apache#285) TICKET = LIKAFKA-40747 LI_DESCRIPTION = A potential reason for NoOffsetForPartitionException is the transition of FetchState for partitions to any state other than INITIALIZING (e.g. offset_reset). However, there are not enough logs on the client side to see if that was the case. Add logs in the exception message to track the actual fetch state of partitions when a NoOffsetForPartitionException is thrown. (cherry picked from commit aaf8c8d)
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.