MINOR: putting back kstream stateful transform methods#292
MINOR: putting back kstream stateful transform methods#292ymatsuda wants to merge 2 commits intoapache:trunkfrom
Conversation
There was a problem hiding this comment.
The functionality of process() now is completely covered by transform: users can define a transform function with return type R be "Void" and add a dummy "return null" in the end of the function. And then in KStream we can add
public void transform(TransformerSupplier<K, V, Void>)
to replace the "process()" call. Having both process() and transform() might be confusing to users, so I would suggest we just remove process() here.
There was a problem hiding this comment.
This would require a separate KStreamVoidTransformProcessor, but I feel it worth the internal cost for simpler public APIs.
|
Talked to @ymatsuda offline about the semantics of process() and transform(), I am now convinced that we may better keep both of them since making transform() return void may be as awkward for end users as well. so LGTM. |
An exception is caught and marked 'ignored' even though it's actually used in the catch block. Declare the caught Exception.
This should solve potential issues with concurrent deletion of files and generally speed up the procedure.
This should solve potential issues with concurrent deletion of files and generally speed up the procedure.
@guozhangwang