Skip to content

MINOR: putting back kstream stateful transform methods#292

Closed
ymatsuda wants to merge 2 commits intoapache:trunkfrom
ymatsuda:transform_method
Closed

MINOR: putting back kstream stateful transform methods#292
ymatsuda wants to merge 2 commits intoapache:trunkfrom
ymatsuda:transform_method

Conversation

@ymatsuda
Copy link
Copy Markdown
Contributor

@ymatsuda ymatsuda commented Oct 9, 2015

@guozhangwang

  • added back type safe stateful transform methods (kstream.transform() and kstream.transformValues())
  • changed kstream.process() to void

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality of process() now is completely covered by transform: users can define a transform function with return type R be "Void" and add a dummy "return null" in the end of the function. And then in KStream we can add

public void transform(TransformerSupplier<K, V, Void>)

to replace the "process()" call. Having both process() and transform() might be confusing to users, so I would suggest we just remove process() here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require a separate KStreamVoidTransformProcessor, but I feel it worth the internal cost for simpler public APIs.

@asfgit asfgit closed this in c67ca65 Oct 9, 2015
@guozhangwang
Copy link
Copy Markdown
Contributor

Talked to @ymatsuda offline about the semantics of process() and transform(), I am now convinced that we may better keep both of them since making transform() return void may be as awkward for end users as well. so LGTM.

@ymatsuda ymatsuda deleted the transform_method branch October 26, 2015 21:14
lbradstreet pushed a commit to lbradstreet/kafka that referenced this pull request Apr 2, 2020
An exception is caught and marked 'ignored' even though it's actually used in
the catch block. Declare the caught Exception.
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
This should solve potential issues with concurrent deletion of files and generally speed up the procedure.
jeqo pushed a commit to aiven/kafka that referenced this pull request Jan 16, 2026
This should solve potential issues with concurrent deletion of files and generally speed up the procedure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants