KAFKA-5174: Have at least 2 threads#2982
KAFKA-5174: Have at least 2 threads#2982enothereska wants to merge 2 commits intoapache:trunkfrom enothereska:KAFKA-5174-1-core
Conversation
|
@dguy @guozhangwang please have a look. Note that this causes queryOnRebalance to also fail occasionally in 1 core environments. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
queryOnRebalance continues to fail, will need more investigation after this PR. That investigation is part of #2996 |
| // note that the current implementation increases the number of compaction threads | ||
| // but not flush threads. | ||
| options.setIncreaseParallelism(Runtime.getRuntime().availableProcessors()); | ||
| options.setIncreaseParallelism(Math.max(Runtime.getRuntime().availableProcessors(), 2)); |
There was a problem hiding this comment.
Can you please add a comment explaining why the minimum is 2?
|
LGTM. Merged to trunk. |
|
@guozhangwang also in 0.10.2 please. Thanks. |
…cksDB This fix needs to be backported to 0.10.2 as well. Author: Eno Thereska <eno.thereska@gmail.com> Reviewers: Damian Guy, Ismael Juma, Guozhang Wang Closes #2982 from enothereska/KAFKA-5174-1-core
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
This fix needs to be backported to 0.10.2 as well.