Skip to content

KAFKA-5174: Have at least 2 threads#2982

Closed
enothereska wants to merge 2 commits intoapache:trunkfrom
enothereska:KAFKA-5174-1-core
Closed

KAFKA-5174: Have at least 2 threads#2982
enothereska wants to merge 2 commits intoapache:trunkfrom
enothereska:KAFKA-5174-1-core

Conversation

@enothereska
Copy link
Copy Markdown
Contributor

@enothereska enothereska commented May 5, 2017

This fix needs to be backported to 0.10.2 as well.

@enothereska
Copy link
Copy Markdown
Contributor Author

@dguy @guozhangwang please have a look. Note that this causes queryOnRebalance to also fail occasionally in 1 core environments.

Copy link
Copy Markdown
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfbot
Copy link
Copy Markdown

asfbot commented May 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3542/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot
Copy link
Copy Markdown

asfbot commented May 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3539/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented May 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3548/
Test FAILed (JDK 8 and Scala 2.11).

@enothereska
Copy link
Copy Markdown
Contributor Author

enothereska commented May 5, 2017

queryOnRebalance continues to fail, will need more investigation after this PR. That investigation is part of #2996

// note that the current implementation increases the number of compaction threads
// but not flush threads.
options.setIncreaseParallelism(Runtime.getRuntime().availableProcessors());
options.setIncreaseParallelism(Math.max(Runtime.getRuntime().availableProcessors(), 2));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment explaining why the minimum is 2?

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM. Merged to trunk.

@asfgit asfgit closed this in 257ad52 May 8, 2017
@enothereska
Copy link
Copy Markdown
Contributor Author

@guozhangwang also in 0.10.2 please. Thanks.

asfgit pushed a commit that referenced this pull request May 8, 2017
…cksDB

This fix needs to be backported to 0.10.2 as well.

Author: Eno Thereska <eno.thereska@gmail.com>

Reviewers: Damian Guy, Ismael Juma, Guozhang Wang

Closes #2982 from enothereska/KAFKA-5174-1-core
@asfbot
Copy link
Copy Markdown

asfbot commented May 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/3650/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot
Copy link
Copy Markdown

asfbot commented May 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3640/
Test PASSed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented May 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3644/
Test PASSed (JDK 7 and Scala 2.10).

@enothereska enothereska deleted the KAFKA-5174-1-core branch May 9, 2017 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants