Skip to content

MINOR: Mark AbstractLogCleanerIntegrationTest as an IntegrationTest#3333

Closed
ewencp wants to merge 1 commit intoapache:trunkfrom
ewencp:minor-mark-log-cleaner-integration-test
Closed

MINOR: Mark AbstractLogCleanerIntegrationTest as an IntegrationTest#3333
ewencp wants to merge 1 commit intoapache:trunkfrom
ewencp:minor-mark-log-cleaner-integration-test

Conversation

@ewencp
Copy link
Copy Markdown
Contributor

@ewencp ewencp commented Jun 14, 2017

No description provided.

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jun 14, 2017

@ijuma @dguy This cuts the aggregate test time for core's unit tests in half because one test derived from this class takes about 2.5 minutes.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jun 14, 2017

@ewencp, the reason @dguy didn't do this is the following JUnit issue that was apparently fixed in the unreleased JUnit 4.13:

junit-team/junit4#751

Have you double-checked that we would not be affected by the above?

@asfbot
Copy link
Copy Markdown

asfbot commented Jun 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5272/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot
Copy link
Copy Markdown

asfbot commented Jun 14, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5288/
Test PASSed (JDK 7 and Scala 2.11).

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jun 14, 2017

Nope, still a problem, seems the tests get skipped with the annotation. Just did this as a side effect of noticing how slow the unit tests were...

Search doesn't seem to be showing up a corresponding JIRA to follow up on. Do we plan to follow up and is JUnit 4.13 likely to get released? Seems like it's been quite awhile since 4.12. Don't want to bother with follow up if it'll never be released.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jun 14, 2017

As you say, it doesn't look good for 4.13. It seems like we'll be stuck with this limitation until we migrate to Java 8 and JUnit 5 in 2027. ;)

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jun 20, 2017

Guess I'll close for now since this doesn't work. I'd file a JIRA for this so we don't forget, but since we can't even associate it with a candidate future release number, we'll just have to hope it bothers someone in the future and they think to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants