Skip to content

MINOR: Apply extra serialized rsync step to both parallel and serial paths#3546

Closed
ewencp wants to merge 1 commit intoapache:trunkfrom
ewencp:fix-rsync
Closed

MINOR: Apply extra serialized rsync step to both parallel and serial paths#3546
ewencp wants to merge 1 commit intoapache:trunkfrom
ewencp:fix-rsync

Conversation

@ewencp
Copy link
Copy Markdown
Contributor

@ewencp ewencp commented Jul 18, 2017

No description provided.

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jul 18, 2017

@enothereska @ijuma @hachikuji @dguy Pinging all the folks annoyed by environmental issues. We should still fix the nightlies to do parallel vagrant up and I'm not sure why it's not enabled yet, but this makes the rsync fix work for both paths. I tested myself on AWS with both parallel and serial cluster up.

@asfgit
Copy link
Copy Markdown

asfgit commented Jul 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6155/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link
Copy Markdown

asfgit commented Jul 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6139/
Test PASSed (JDK 8 and Scala 2.12).

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the system tests pass with this change.

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jul 19, 2017

Fired off a job here, though given the massive failures from https://issues.apache.org/jira/browse/KAFKA-5608, who knows whether it'll be meaningful or not...

@enothereska
Copy link
Copy Markdown
Contributor

The system test didn't go through, but the patch looks reasonable.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 19, 2017

The system test run failed during rsync so that's a bit concerning. I restarted it.

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jul 20, 2017

I believe this is the job you started. All the failures appear to be related to the JmxTool issues. However, now that that issue has been resolved, I've restarted the job once again after rebasing against the latest trunk, running how here.

@asfgit
Copy link
Copy Markdown

asfgit commented Jul 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6188/
Test PASSed (JDK 7 and Scala 2.11).

@asfgit
Copy link
Copy Markdown

asfgit commented Jul 20, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6172/
Test FAILed (JDK 8 and Scala 2.12).

@ewencp
Copy link
Copy Markdown
Contributor Author

ewencp commented Jul 20, 2017

System tests have passed now that the other patch went through, so committing and cherry-picking all the way back to 0.10.0

asfgit pushed a commit that referenced this pull request Jul 20, 2017
…paths

Author: Ewen Cheslack-Postava <ewen@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Eno Thereska <eno.thereska@gmail.com>

Closes #3546 from ewencp/fix-rsync

(cherry picked from commit 9b7a6ee)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
asfgit pushed a commit that referenced this pull request Jul 20, 2017
…paths

Author: Ewen Cheslack-Postava <ewen@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Eno Thereska <eno.thereska@gmail.com>

Closes #3546 from ewencp/fix-rsync

(cherry picked from commit 9b7a6ee)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
asfgit pushed a commit that referenced this pull request Jul 20, 2017
…paths

Author: Ewen Cheslack-Postava <ewen@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Eno Thereska <eno.thereska@gmail.com>

Closes #3546 from ewencp/fix-rsync

(cherry picked from commit 9b7a6ee)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
asfgit pushed a commit that referenced this pull request Jul 20, 2017
…paths

Author: Ewen Cheslack-Postava <ewen@confluent.io>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Eno Thereska <eno.thereska@gmail.com>

Closes #3546 from ewencp/fix-rsync

(cherry picked from commit 9b7a6ee)
Signed-off-by: Ewen Cheslack-Postava <me@ewencp.org>
@asfgit asfgit closed this in 9b7a6ee Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants