[DO NOT MERGE] KAFKA-3705: non-key joins#3720
Closed
guozhangwang wants to merge 8 commits intoapache:trunkfrom
Closed
[DO NOT MERGE] KAFKA-3705: non-key joins#3720guozhangwang wants to merge 8 commits intoapache:trunkfrom
guozhangwang wants to merge 8 commits intoapache:trunkfrom
Conversation
Kaiserchen
reviewed
Aug 23, 2017
| * | ||
| */ | ||
|
|
||
| KeyValueIterator<K, V> prefixScan(K prefix); |
There was a problem hiding this comment.
@guozhangwang this is controversal and needs discussion. We use the same type for prefix and key. Currently I rely on the Serde to only render a prefix. that works fantastic with protobuf,avro and String might be the worst nightmare for JSON people
Kaiserchen
reviewed
Aug 23, 2017
| */ | ||
| <K0, V0, KO, VO> KTable<K0, V0> oneToManyJoin(KTable<KO, VO> other, | ||
| ValueMapper<VO, K> keyExtractor, | ||
| ValueMapper<K, K0> joinPrefixFaker, |
There was a problem hiding this comment.
Same controversy as with the Store prefix(K)
Kaiserchen
reviewed
Aug 23, 2017
| * @param joiner | ||
| * @return | ||
| */ | ||
| <K0, V0, KO, VO> KTable<K0, V0> oneToManyJoin(KTable<KO, VO> other, |
There was a problem hiding this comment.
returns new K0 wich needs to contain K and K0. I love how this works so i expect controversy here aswell
3 tasks
Contributor
Author
|
Closing this PR as it is already addressed by @bellemare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for reviewing the diff easily to see how it is done by @jfilipiak @Kaiserchen