Make ByteBufferInputStream.read(byte[], int, int) to follow the contract#3752
Closed
leventov wants to merge 1 commit intoapache:trunkfrom
Closed
Make ByteBufferInputStream.read(byte[], int, int) to follow the contract#3752leventov wants to merge 1 commit intoapache:trunkfrom
leventov wants to merge 1 commit intoapache:trunkfrom
Conversation
ijuma
reviewed
Aug 31, 2017
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR. It would be good to add a test in ByteBufferLogInputStreamTest to verify the fix.
Member
|
@leventov Do you want to activate this PR? If not, I'd like to file a PR to complete it with a test case :) |
Member
Author
|
@chia7712 go for it |
Member
|
@leventov Thanks for your response. I'm going to close this PR. see https://issues.apache.org/jira/browse/KAFKA-10768 as follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.