Skip to content

KAFKA-2687: Add support for ListGroups and DescribeGroup APIs#388

Closed
hachikuji wants to merge 8 commits intoapache:trunkfrom
hachikuji:K2687
Closed

KAFKA-2687: Add support for ListGroups and DescribeGroup APIs#388
hachikuji wants to merge 8 commits intoapache:trunkfrom
hachikuji:K2687

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

No description provided.

@hachikuji
Copy link
Copy Markdown
Contributor Author

@junrao Ping for review. A few comments:

  1. DescribeGroup in this initial patch only accepts one groupId. Should be straightforward to modify it to accept and return an array instead.
  2. I haven't done so yet, but I think it would make sense to rename GroupMetadataRequest to GroupCoordinatorRequest.
  3. I included an AdminClient to help with integration testing. This doesn't necessarily need to be included in this patch, but it seems like we'll need this functionality to implement ConsumerGroupCommand for the new consumer.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's useful for an admin client to distinguish the two states?

@hachikuji
Copy link
Copy Markdown
Contributor Author

@junrao Ready for another look.

@junrao
Copy link
Copy Markdown
Contributor

junrao commented Nov 2, 2015

Thanks for the patch. Other than making DescribeGroup take an array of groups, it looks good.

@hachikuji
Copy link
Copy Markdown
Contributor Author

@junrao Added a couple commits to rename GroupMetadataRequest to GroupCoordinatorRequest and allow DescribeGroup to work with multiple groups.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ByteBuffer.allocate(0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants