KAFKA-5929: Save pre-assignment to file to avoid too long text to display when do topic partition reassign#3897
Closed
uncleGen wants to merge 3 commits intoapache:trunkfrom
Closed
KAFKA-5929: Save pre-assignment to file to avoid too long text to display when do topic partition reassign#3897uncleGen wants to merge 3 commits intoapache:trunkfrom
uncleGen wants to merge 3 commits intoapache:trunkfrom
Conversation
… topic partition reassign
uncleGen
force-pushed
the
KAFKA-5929
branch
from
9a78be3 to
b5806c9
Compare
uncleGen
force-pushed
the
KAFKA-5929
branch
from
9483c6d to
19d3f84
Compare
Contributor
Author
|
retest this please |
Contributor
Author
|
ready for review |
Contributor
Author
|
@lindong28 Could you please take a review? |
|
FAILURE |
1 similar comment
|
FAILURE |
|
SUCCESS |
lindong28
reviewed
Nov 15, 2017
Member
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
The patch LGTM overall. Left one comment.
I think this is a improvement but not that necessary. Usually I would re-direct output via pipe to another file. Committer can decide whether to accept or not.
| } | ||
|
|
||
| def executeAssignment(zkUtils: ZkUtils, adminClientOpt: Option[JAdminClient], reassignmentJsonString: String, throttle: Throttle, timeoutMs: Long = 10000L) { | ||
| def executeAssignment(zkUtils: ZkUtils, adminClientOpt: Option[JAdminClient], reassignmentJsonString: String, reassignmentJsonFile: String, throttle: Throttle, timeoutMs: Long = 10000L) { |
Member
There was a problem hiding this comment.
making reassignmentJsonFile an Option[String] is probably better than using empty to indicate that it is not used.
Contributor
Author
There was a problem hiding this comment.
get it, thanks for your review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When do partition reassign
before pr
Pre-assignment will be printed directly. It is not friendly when the text is too long.
after pr
Pre-assignment will still be printed directly, but will be save to a file at the same time, naming with suffix ".rollback" of "reassignment-json-file". For example:
then we may get a file test.json.rollback