KAFKA-2748: Ensure sink tasks commit offsets upon rebalance and rewind if the SinkTask flush fails.#431
Closed
ewencp wants to merge 2 commits intoapache:trunkfrom
Closed
Conversation
…d if the SinkTask flush fails. Also fix the incorrect consumer group ID setting which was giving each task its own group instead of one for the entire sink connector.
Contributor
There was a problem hiding this comment.
Comment: no returns for this function.
Contributor
|
LGTM, one minor comment. |
hachikuji
pushed a commit
to hachikuji/kafka
that referenced
this pull request
Nov 3, 2020
* Add CurrentState to BrokerHeartbeatRequest * Create BrokerLifecycleManager * Create BrokerLifecycleManagerTest, ControllerApisTest
sutambe
pushed a commit
to sutambe/kafka
that referenced
this pull request
Feb 23, 2023
TICKET = N/A EXIT_CRITERIA = When we have better metrics exposed and no longer need to get it via log parsing LI_DESCRIPTION = An internal dashboard depends on extracting information from instances of this logline. Changing the format may break the parsing.
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
SDK instances were separated by component to avoid sharing the same connection pools 08bd9f5 --this lead inadvertently to metrics not being exported as the same MBeans were created multiple times. To fix this, this change creates a single instance statically, and is reused across instances. This has another side effect on how metrics are tested: metrics are now shared across tests (as it is created statically) this leads to results being accumulate, and affecting other tests if metrics are closed. To workaround this, metric sensors are removed to restart the metrics (similar pattern to yammer metrics used in other places within the broker). As a note for further improving how metrics are collected: Redefining this would require further refactoring to only create a single metrics per broker or similar.
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
SDK instances were separated by component to avoid sharing the same connection pools 08bd9f5 --this lead inadvertently to metrics not being exported as the same MBeans were created multiple times. To fix this, this change creates a single instance statically, and is reused across instances. This has another side effect on how metrics are tested: metrics are now shared across tests (as it is created statically) this leads to results being accumulate, and affecting other tests if metrics are closed. To workaround this, metric sensors are removed to restart the metrics (similar pattern to yammer metrics used in other places within the broker). As a note for further improving how metrics are collected: Redefining this would require further refactoring to only create a single metrics per broker or similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix the incorrect consumer group ID setting which was giving each task its
own group instead of one for the entire sink connector.