Skip to content

HOTFIX: unsubscribe does not clear user assignment properly #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hachikuji wants to merge 1 commit into from
Closed

HOTFIX: unsubscribe does not clear user assignment properly #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ public boolean hasPatternSubscription() {

public void unsubscribe() {
this.subscription.clear();
this.userAssignment.clear();
this.assignment.clear();
this.needsPartitionAssignment = true;
this.subscribedPattern = null;
Expand Down
16 changes: 16 additions & 0 deletions clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,22 @@ public void patternSubscription() {
"Expected subscribed topics count is incorrect", 2, state.subscription().size());
}

@Test
public void unsubscribeUserAssignment() {
state.assignFromUser(Arrays.asList(tp0, tp1));
state.unsubscribe();
state.subscribe(Arrays.asList(topic), rebalanceListener);
assertEquals(Collections.singleton(topic), state.subscription());
}

@Test
public void unsubscribeUserSubscribe() {
state.subscribe(Arrays.asList(topic), rebalanceListener);
state.unsubscribe();
state.assignFromUser(Arrays.asList(tp0));
assertEquals(Collections.singleton(tp0), state.assignedPartitions());
}

@Test
public void unsubscription() {
state.subscribe(Pattern.compile(".*"), rebalanceListener);
Expand Down