Skip to content

MINOR need to get a new transformer for each get() call. can't share'em#4435

Merged
guozhangwang merged 1 commit intoapache:trunkfrom
norwood:get-in-get-get-it
Jan 18, 2018
Merged

MINOR need to get a new transformer for each get() call. can't share'em#4435
guozhangwang merged 1 commit intoapache:trunkfrom
norwood:get-in-get-get-it

Conversation

@norwood
Copy link
Copy Markdown
Contributor

@norwood norwood commented Jan 18, 2018

@jeyhunkarimov @mjsax @guozhangwang

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

LGTM.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add final

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add final

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add final

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add final

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM.

@jeyhunkarimov
Copy link
Copy Markdown
Contributor

Sorry for the buggy leftover. Thanks @norwood for the fix.

@guozhangwang guozhangwang merged commit 5701ba8 into apache:trunk Jan 18, 2018
@mjsax mjsax mentioned this pull request Nov 7, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants