MINOR Fix AsyncProducerTest bug that hits when logging is turned up#4450
Merged
ijuma merged 1 commit intoapache:trunkfrom Apr 11, 2018
Merged
MINOR Fix AsyncProducerTest bug that hits when logging is turned up#4450ijuma merged 1 commit intoapache:trunkfrom
ijuma merged 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
The error message when logging is set to TRACE looks like this: |
Member
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
Author
|
Another Jenkins infrastructure failure (no build or testing was done): |
Contributor
Author
|
retest this please |
Contributor
Author
|
I filed https://issues.apache.org/jira/browse/INFRA-15903 for the Jenkins issue. We have seen it before. |
Contributor
Author
|
Another unrelated failure in |
f63489e to
7cd1f4a
Compare
Contributor
Author
|
JDK7 failure was streams test timeout. Will retry. |
Contributor
Author
|
Retest this please |
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
Author
|
retest this please |
AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of using a mock, just create a real SyncProducerConfig object, since the object is simple to create.
7cd1f4a to
b162029
Compare
Contributor
Author
|
The test run succeeded, but then jenkins got this: |
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pache#4450) AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of usIng a mock, just create a real SyncProducerConfig object, since the object is simple to create. Reviewers: Ismael Juma <ismael@juma.me.uk>
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pache#4450) AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of usIng a mock, just create a real SyncProducerConfig object, since the object is simple to create. Reviewers: Ismael Juma <ismael@juma.me.uk>
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pache#4450) AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of usIng a mock, just create a real SyncProducerConfig object, since the object is simple to create. Reviewers: Ismael Juma <ismael@juma.me.uk>
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…pache#4450) AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of usIng a mock, just create a real SyncProducerConfig object, since the object is simple to create. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncProducerTest gets an error about an incorrect mock when the logging
level is turned up. Instead of using a mock, just create a real
SyncProducerConfig object, since the object is simple to create.