Skip to content

Kafka-3832: Kafka Connect's JSON Converter never outputs a null value#4534

Closed
Satyajitv wants to merge 1 commit intoapache:trunkfrom
Satyajitv:KAFKA-3832
Closed

Kafka-3832: Kafka Connect's JSON Converter never outputs a null value#4534
Satyajitv wants to merge 1 commit intoapache:trunkfrom
Satyajitv:KAFKA-3832

Conversation

@Satyajitv
Copy link
Copy Markdown

@Satyajitv Satyajitv commented Feb 6, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

@rhauch , have added null condition in the method convertToJsonWithEnvelope ,to return null instead of empty Envelope, when enableSchemas=true.

Would also implement a similar change to toConnectData method, based on your feedback with changes made for fromConnectData method.

let me know, if there is any problem with the implementation or my understanding about the KAFKA-3832.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ewencp ewencp added the connect label Feb 28, 2018
@kkonstantine
Copy link
Copy Markdown
Contributor

This issue has been fixed.

Closing this PR without merging given that KAFKA-3832 was actually fixed by #6027 but thanks for taking an initial stab at this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants