KAFKA-6054: Fix upgrade path from Kafka Streams v0.10.0#4761
KAFKA-6054: Fix upgrade path from Kafka Streams v0.10.0#4761mjsax merged 4 commits intoapache:0.11.0from
Conversation
|
Upgrade system test passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1573/ Triggered all Streams system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1574/ (Passed) Note: Java 9 does not work on old |
4e82244 to
8e9597b
Compare
|
Updated this. System test passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1593/ |
Github comments John's review Guozhang's follow up
8e9597b to
cfc3e6a
Compare
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM. Just left some comments on the web docs.
| <h5><a id="upgrade_1020_streams_from_0100" href="#upgrade_1020_streams_from_0100">Upgrading a 0.10.0 Kafka Streams Application</a></h5> | ||
| <ul> | ||
| <li> Upgrading your Streams application from 0.10.0 to 0.10.2 does require a <a href="#upgrade_10_1">broker upgrade</a> because a Kafka Streams 0.10.2 application can only connect to 0.10.2 or 0.10.1 brokers. </li> | ||
| <li> There are couple of API changes, that are not backward compatible (cf. <a href="/{{version}}/documentation/streams#streams_api_changes_0102">Streams API changes in 0.10.2</a> for more details). |
There was a problem hiding this comment.
Could we just ref-link the streams/upgrade-guide.html here than copying the content again in the main upgrade section?
There was a problem hiding this comment.
We can. It's "break" the established pattern though. Up to now, those older sections are just the unchanged release notes from the version before -- I just followed the structure of the existing docs. Let me know what you think. Also, I am wondering, it this changes anyway if we rework the web page from scratch as anticipated.
There was a problem hiding this comment.
Sounds good. We can leave it as is then.
| <li> Upgrading your Streams application from 0.10.0 to 0.10.1 does require a <a href="#upgrade_10_1">broker upgrade</a> because a Kafka Streams 0.10.1 application can only connect to 0.10.1 brokers. </li> | ||
| <li> There are couple of API changes, that are not backward compatible (cf. <a href="/{{version}}/documentation/streams#streams_api_changes_0101">Streams API changes in 0.10.1</a> for more details). | ||
| Thus, you need to update and recompile your code. Just swapping the Kafka Streams library jar file will not work and will break your application. </li> | ||
| <li> Upgrading from 0.10.0.x to 0.10.1.2 requires two rolling bounces with config <code>upgrade.from="0.10.0"</code> set for first upgrade phase |
There was a problem hiding this comment.
Strictly speaking we cannot yet talk about 0.10.1.2 in 0.11.0.3 yet since we may not release 0.10.1.2 before releasing 0.11.0.3. I think it may not be of a big issue still leaving this here, but just try to point it out.
There was a problem hiding this comment.
You are right -- not sure how to resolve this... Maybe we can only fix this manually when an older bug fix release is done... It's a little annoying :(
|
retest this please |
|
Retest this please. |
4a7d4a6 to
31dca1a
Compare
|
Merged to |
No description provided.