Skip to content

HOTFIX: Enforce a rebalance upon task migration #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 2 commits into from
Mar 31, 2018
Merged

HOTFIX: Enforce a rebalance upon task migration #4802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea92e0
enforce rebalance
guozhangwang Mar 30, 2018
568fd37
improve on error message
guozhangwang Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions streams/src/main/java/org/apache/kafka/streams/errors/TaskMigratedException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public class TaskMigratedException extends StreamsException {

private final static long serialVersionUID = 1L;

private final Task task;

public TaskMigratedException(final Task task) {
this(task, null);
}
Expand All @@ -36,17 +38,24 @@ public TaskMigratedException(final Task task,
final TopicPartition topicPartition,
final long endOffset,
final long pos) {
super(String.format("Log end offset of %s should not change while restoring: old end offset %d, current offset %d%n%s",
topicPartition,
endOffset,
pos,
task.toString("> ")),
null);
super(String.format("Log end offset of %s should not change while restoring: old end offset %d, current offset %d",
topicPartition,
endOffset,
pos),
null);

this.task = task;
}

public TaskMigratedException(final Task task,
final Throwable throwable) {
super(task.toString(), throwable);

this.task = task;
}

public Task migratedTask() {
return task;
}

}
11 changes: 8 additions & 3 deletions streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,9 +749,14 @@ private void runLoop() {
try {
recordsProcessedBeforeCommit = runOnce(recordsProcessedBeforeCommit);
} catch (final TaskMigratedException ignoreAndRejoinGroup) {
log.warn("Detected a task that got migrated to another thread. " +
"This implies that this thread missed a rebalance and dropped out of the consumer group. " +
"Trying to rejoin the consumer group now.", ignoreAndRejoinGroup);
log.warn("Detected task {} that got migrated to another thread: {} " +
"This implies that the thread may have missed a rebalance and dropped out of the consumer group. " +
"Will try to rejoin the consumer group. Below is the detailed description of the task:\n{}",
ignoreAndRejoinGroup.migratedTask().id(), ignoreAndRejoinGroup.getMessage(), ignoreAndRejoinGroup.migratedTask().toString(">"));

// re-subscribe to enforce a rebalance in the next poll call
consumer.unsubscribe();
consumer.subscribe(builder.sourceTopicPattern(), rebalanceListener);
}
}
}
Expand Down