Skip to content

MINOR: Make kafka-streams-test-utils dependencies work with releases tarballs #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ewencp wants to merge 1 commit into from
Closed

MINOR: Make kafka-streams-test-utils dependencies work with releases tarballs #4816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,9 +968,18 @@ project(':streams:test-utils') {
archivesBaseName = "kafka-streams-test-utils"

dependencies {
compile project(':streams').sourceSets.main.output
// streams and streams-test-utils have a circular dependency that needs to be broken. Making streams a regular
// compile dependency here is a circular dependency. Making the streams project's main sourceSet output a dependency
// incorrectly includes raw class files as dependencies and ends up including them in output like the release tgz.
// Making the main sourceSet's output a compileOnly (provided) dependency resolves the circular dependency in gradle
// and also leaves the raw class files out of the output. This does require that users of this jar specify the
// streams dependency separately, but they wouldn't be using this module in tests unless they already had a
// compile dependency on streams. For this module, however, we need to also include streams as a separate test
// dependency since it is compileOnly/provided for the compile phase.
compileOnly project(':streams').sourceSets.main.output
compile project(':clients')

testCompile project(':streams')
testCompile project(':clients').sourceSets.test.output
testCompile libs.junit
testCompile libs.rocksDBJni
Expand Down