KAFKA-6768; Transactional producer may hang in close with pending requests#4842
Merged
hachikuji merged 1 commit intoapache:trunkfrom Apr 9, 2018
Merged
KAFKA-6768; Transactional producer may hang in close with pending requests#4842hachikuji merged 1 commit intoapache:trunkfrom
hachikuji merged 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
hachikuji
commented
Apr 9, 2018
|
|
||
| AbstractRequest.Builder<?> requestBuilder = nextRequestHandler.requestBuilder(); | ||
| while (running) { | ||
| while (!forceClose) { |
Contributor
Author
There was a problem hiding this comment.
The problem was basically that initiateClose set running to true, which prevented the transactional request from being sent. That in turn kept batched records stuck in the accumulator and prevented shutdown from completing.
Contributor
There was a problem hiding this comment.
nit (for documentation): initiateClose would set running to false.
Contributor
Author
|
For the record, I was able to reproduce the failure in 4/32 runs of our transaction system tests. With this patch, I did not see any failures in 32 runs. |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…uests (apache#4842) This patch fixes an edge case in producer shutdown which prevents `close()` from completing due to a pending request which will never be sent due to shutdown initiation. I have added a test case which reproduces the scenario. Reviewers: Apurva Mehta <apurva@confluent.io>, Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an edge case in producer shutdown which prevents
close()from completing due to a pending request which will never be sent due to shutdown initiation. I have added a test case which reproduces the scenario.Committer Checklist (excluded from commit message)