Make [Config]Resource.toString() consistent with existing code#4845
Merged
rajinisivaram merged 1 commit intoapache:trunkfrom Apr 10, 2018
Merged
Make [Config]Resource.toString() consistent with existing code#4845rajinisivaram merged 1 commit intoapache:trunkfrom
rajinisivaram merged 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
rajinisivaram
approved these changes
Apr 10, 2018
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@edenhill Thanks for the PR, LGTM.
Contributor
|
Test failures are unrelated, merging to trunk. |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…e#4845) The toString() for ConfigResource was using { } instead of ( ) which is inconsistent with the existing toStrings in the code, while toString for Resource was using a mix of ( and }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toString() for ConfigResource was using { } instead of ( ) which is inconsistent with the existing toStrings in the code,
while toString for Resource was using a mix of ( and }.