MINOR: Move creation of quota callback to ensure single instance#4848
Merged
rajinisivaram merged 1 commit intoapache:trunkfrom Apr 10, 2018
Merged
MINOR: Move creation of quota callback to ensure single instance#4848rajinisivaram merged 1 commit intoapache:trunkfrom
rajinisivaram merged 1 commit intoapache:trunkfrom
Conversation
junrao
approved these changes
Apr 10, 2018
Contributor
junrao
left a comment
junrao
left a comment
There was a problem hiding this comment.
@rajinisivaram : Thanks for the patch. LGTM
Contributor
Author
|
@junrao Thanks for the review, merging to trunk. |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…che#4848) Move creation of quota callback instance out of KafkaConfig constructor to QuotaFactory.instantiate to avoid creating a callback instance for every KafkaConfig since we create temporary KafkaConfigs during dynamic config updates. Reviewers: Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move creation of quota callback instance out of KafkaConfig constructor to
QuotaFactory.instantiateto avoid creating a callback instance for every KafkaConfig since we create temporary KafkaConfigs during dynamic config updates.Committer Checklist (excluded from commit message)