Skip to content

KAFKA-4883: handle NullPointerException while parsing login modue control flag #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajinisivaram merged 1 commit into from
Apr 10, 2018
Merged

KAFKA-4883: handle NullPointerException while parsing login modue control flag #4849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clients/src/main/java/org/apache/kafka/common/security/JaasConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String name) {
}

private LoginModuleControlFlag loginModuleControlFlag(String flag) {
if (flag == null)
throw new IllegalArgumentException("Login module control flag is not available in the JAAS config");

LoginModuleControlFlag controlFlag;
switch (flag.toUpperCase(Locale.ROOT)) {
case "REQUIRED":
Expand Down
5 changes: 5 additions & 0 deletions clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,11 @@ public void testNumericOptionWithoutQuotes() throws Exception {
checkInvalidConfiguration("test.testNumericOptionWithoutQuotes required option1=3;");
}

@Test
public void testInvalidControlFlag() throws Exception {
checkInvalidConfiguration("test.testInvalidControlFlag { option1=3;");
}

@Test
public void testNumericOptionWithQuotes() throws Exception {
Map<String, Object> options = new HashMap<>();
Expand Down