KAFKA-6773; Allow offset commit/fetch/describe with empty groupId#4851
Merged
hachikuji merged 6 commits intoapache:trunkfrom Apr 11, 2018
Merged
KAFKA-6773; Allow offset commit/fetch/describe with empty groupId#4851hachikuji merged 6 commits intoapache:trunkfrom
hachikuji merged 6 commits intoapache:trunkfrom
Conversation
ijuma
approved these changes
Apr 10, 2018
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
LGTM, just a couple of minor comments.
| val groupId = "" | ||
|
|
||
| val commitOffsetResult = commitOffsets(groupId, OffsetCommitRequest.DEFAULT_MEMBER_ID, | ||
| OffsetCommitRequest.DEFAULT_GENERATION_ID, immutable.Map(tp -> offset)) |
Contributor
Author
There was a problem hiding this comment.
I think it's because we import scala.collection._. Will try to fix.
Member
There was a problem hiding this comment.
Makes sense. You can leave it as is, I was just curious.
|
|
||
| private def validateGroup(groupId: String): Option[Errors] = { | ||
| if (!validGroupId(groupId)) | ||
| private def validateNonEmptyGroupStatus(groupId: String): Option[Errors] = { |
Member
There was a problem hiding this comment.
Can we add a comment saying that this is only used by commit and fetch and why?
Contributor
Author
|
@ijuma Thanks, you should probably take another look before I merge since I changed a few things. I had initially not allowed support for the empty group id in DeleteGroups. |
ijuma
approved these changes
Apr 11, 2018
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Just a trivial comment, LGTM (no need for re-review).
|
|
||
| @Test | ||
| def testCommitAndFetchOffsetsWithEmptyGroup() { | ||
| // For backwards compatibility, the coordinator supports committing/fetching offsets with an empty groupId |
Member
There was a problem hiding this comment.
Do you want to mention the reason for describe/delete group in the test as well?
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pId (apache#4851) We had a regression in apache#4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. Additionally, I have modified DeleteGroups to allow removal of the empty group, which was missed in the initial implementation. I've added a test case to ensure that we do not miss this again in the future. Reviewers: Ismael Juma <ismael@juma.me.uk>
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pId (apache#4851) We had a regression in apache#4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. Additionally, I have modified DeleteGroups to allow removal of the empty group, which was missed in the initial implementation. I've added a test case to ensure that we do not miss this again in the future. Reviewers: Ismael Juma <ismael@juma.me.uk>
koqizhao
pushed a commit
to koqizhao/kafka
that referenced
this pull request
Apr 12, 2018
…pId (apache#4851) We had a regression in apache#4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. Additionally, I have modified DeleteGroups to allow removal of the empty group, which was missed in the initial implementation. I've added a test case to ensure that we do not miss this again in the future. Reviewers: Ismael Juma <ismael@juma.me.uk>
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…pId (apache#4851) We had a regression in apache#4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. Additionally, I have modified DeleteGroups to allow removal of the empty group, which was missed in the initial implementation. I've added a test case to ensure that we do not miss this again in the future. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a regression in #4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. I've added a test case to ensure that we do not miss this again in the future.
Committer Checklist (excluded from commit message)