Skip to content

KAFKA-6784: FindCoordinatorResponse cannot be cast to FetchResponse#4865

Closed
koqizhao wants to merge 1 commit intoapache:trunkfrom
koqizhao:KAFKA-6784
Closed

KAFKA-6784: FindCoordinatorResponse cannot be cast to FetchResponse#4865
koqizhao wants to merge 1 commit intoapache:trunkfrom
koqizhao:KAFKA-6784

Conversation

@koqizhao
Copy link
Copy Markdown

fix bug: FindCoordinatorResponse cannot be cast to FetchResponse

@koqizhao
Copy link
Copy Markdown
Author

koqizhao commented Apr 13, 2018

JDK 8 and Scala 2.12 case fail:
kafka.api.ClientIdQuotaTest.testThrottledProducerConsumer
It's caused by another bug (opened as KAFKA-6787). No need fix it here.

java.lang.NullPointerException
at org.apache.kafka.common.metrics.stats.SampledStat.purgeObsoleteSamples(SampledStat.java:104)
at org.apache.kafka.common.metrics.stats.SampledStat.measure(SampledStat.java:74)
at org.apache.kafka.common.metrics.KafkaMetric.metricValue(KafkaMetric.java:68)
at kafka.api.QuotaTestClients$.metricValue(BaseQuotaTest.scala:163)
at kafka.api.QuotaTestClients.produceUntilThrottled(BaseQuotaTest.scala:193)
at kafka.api.BaseQuotaTest.testThrottledProducerConsumer(BaseQuotaTest.scala:84)

@hachikuji
Copy link
Copy Markdown
Contributor

Thanks for the PR. I agree this would fix the problem, but the fact that the error is happening in the first place suggests that we have a bug somewhere else in the code. Do you have a way to reproduce the problem?

@koqizhao
Copy link
Copy Markdown
Author

It's found when running test case. Cannot be reproduced stably. I will have a try sometime.

@hachikuji
Copy link
Copy Markdown
Contributor

@koqizhao The test case itself may have a bug. Do you know which one causes it?

@koqizhao
Copy link
Copy Markdown
Author

@hackikuji, test case is
kafka.api.ClientIdQuotaTest.testThrottledProducerConsumer

cannot be repro stably.

@koqizhao koqizhao closed this Jul 17, 2018
@koqizhao koqizhao deleted the KAFKA-6784 branch July 17, 2018 01:47
@koqizhao koqizhao restored the KAFKA-6784 branch July 17, 2018 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants