Skip to content

KAFKA-3355: Fix GetOffsetShell doesn't work with SASL enabled Kafka#5028

Closed
murong00 wants to merge 1 commit intoapache:0.10.1from
murong00:0.10.1
Closed

KAFKA-3355: Fix GetOffsetShell doesn't work with SASL enabled Kafka#5028
murong00 wants to merge 1 commit intoapache:0.10.1from
murong00:0.10.1

Conversation

@murong00
Copy link
Copy Markdown
Contributor

As described in JIRA: KAFKA-3355, i fixed this issue for kafka 0.10.1.1 in production systems, hoping it may help users with this version.

@mgarmes
Copy link
Copy Markdown

mgarmes commented May 21, 2018

HI @murong00 ,
I guess your PR is the same as #2891 !!
Bests

@omkreddy
Copy link
Copy Markdown
Contributor

@ijuma Can we review this before removing old consumer code? or Are we going to remove GetOffsetShell?

@ijuma
Copy link
Copy Markdown
Member

ijuma commented May 26, 2018

Yes, #2891 was submitted first, so let's try to get that in instead. Also it builds on public APIs instead of the Scala AdminClient.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented May 26, 2018

Actually #3051 is the one that builds on public APIs, but that requires a KIP. So, maybe it makes sense to go with #2891 first and then do #3051.

@ijuma ijuma closed this May 26, 2018
@ijuma
Copy link
Copy Markdown
Member

ijuma commented May 26, 2018

Hmm, on second thought, we should probably go with a reduced version of #3051 since #2891 adds methods to the Scala AdminClient that we don't want to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants