KAFKA-3355: Fix GetOffsetShell doesn't work with SASL enabled Kafka#5028
Closed
murong00 wants to merge 1 commit intoapache:0.10.1from
murong00:0.10.1
Closed
KAFKA-3355: Fix GetOffsetShell doesn't work with SASL enabled Kafka#5028murong00 wants to merge 1 commit intoapache:0.10.1from murong00:0.10.1
murong00 wants to merge 1 commit intoapache:0.10.1from
murong00:0.10.1
Conversation
Contributor
|
@ijuma Can we review this before removing old consumer code? or Are we going to remove GetOffsetShell? |
Member
|
Yes, #2891 was submitted first, so let's try to get that in instead. Also it builds on public APIs instead of the Scala AdminClient. |
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in JIRA: KAFKA-3355, i fixed this issue for kafka 0.10.1.1 in production systems, hoping it may help users with this version.