KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 3]#5052
Merged
guozhangwang merged 2 commits intoapache:trunkfrom May 22, 2018
Merged
KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 3]#5052guozhangwang merged 2 commits intoapache:trunkfrom
guozhangwang merged 2 commits intoapache:trunkfrom
Conversation
* Refactor: - KStreamWindowReduceTest - KTableMapKeysTest - SessionWindowedKStreamImplTest - TimeWindowedKStreamImplTest
Member
mjsax
approved these changes
May 21, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
Waiting for second review and Jenkins to pass before merging.
guozhangwang
approved these changes
May 21, 2018
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Left a couple comments on checking @SuppressWarnings("unchecked"). Otherwise LGTM!
| processData(); | ||
| final SessionStore<String, String> sessionStore = (SessionStore<String, String>) driver.allStateStores().get("reduced"); | ||
| final List<KeyValue<Windowed<String>, String>> data = StreamsTestUtils.toList(sessionStore.fetch("1", "2")); | ||
| try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props, 0L)) { |
Contributor
There was a problem hiding this comment.
I think some of the above @SuppressWarnings("unchecked") can be removed now as well; could you double check?
Contributor
Author
There was a problem hiding this comment.
Yes, they can. Thank for catching this.
| processData(); | ||
| final WindowStore<String, String> windowStore = (WindowStore<String, String>) driver.allStateStores().get("reduced"); | ||
| final List<KeyValue<Windowed<String>, String>> data = StreamsTestUtils.toList(windowStore.fetch("1", "2", 0, 1000)); | ||
| try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props, 0L)) { |
Contributor
There was a problem hiding this comment.
Ditto here for @SuppressWarnings("unchecked") above?
Member
|
retest this please |
Contributor
Author
|
I keep getting an (unrelated) timeout error on |
Contributor
|
@h314to This is a known issue and is being fixed. |
Contributor
|
Merged to trunk, thanks @h314to ! |
Contributor
Author
|
Great! :) |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…3] (apache#5052) * KAFKA-6474: Rewrite tests to use new public TopologyTestDriver [part 3] * Refactor: - KStreamWindowReduceTest - KTableMapKeysTest - SessionWindowedKStreamImplTest - TimeWindowedKStreamImplTest * Remove unnecessary @SuppressWarnings(unchecked) Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a further step towards the complete replacement of
KStreamTestDriverwithTopologyTestDriver. These straightforward changes were split from another PR to simplify the review process.