Skip to content

KAFKA-7000: update assignment in Consumer#position #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vvcephei wants to merge 2 commits into from
Closed

KAFKA-7000: update assignment in Consumer#position #5142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92249f3
KAFKA-7000: update assignment in Consumer#position
vvcephei Jun 5, 2018
3610615
modify test to avoid recursive call to self
vvcephei Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,6 +1611,7 @@ public long position(TopicPartition partition, final Duration timeout) {
final long timeoutMs = timeout.toMillis();
acquireAndEnsureOpen();
try {
coordinator.poll(timeout.toMillis());
if (!this.subscriptions.isAssigned(partition))
throw new IllegalStateException("You can only check the position for partitions assigned to this consumer.");
Long offset = this.subscriptions.position(partition);
Expand Down
5 changes: 1 addition & 4 deletions core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ class PlaintextConsumerTest extends BaseConsumerTest {
consumers += consumer0

var commitCompleted = false
var committedPosition: Long = -1

val listener = new TestConsumerReassignmentListener {
override def onPartitionsRevoked(partitions: util.Collection[TopicPartition]): Unit = {
Expand All @@ -190,8 +189,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
// than session timeout and then try a commit. We should still be in the group,
// so the commit should succeed
Utils.sleep(1500)
committedPosition = consumer0.position(tp)
consumer0.commitSync(Map(tp -> new OffsetAndMetadata(committedPosition)).asJava)
consumer0.commitSync(Map(tp -> new OffsetAndMetadata(0)).asJava)
commitCompleted = true
}
super.onPartitionsRevoked(partitions)
Expand All @@ -207,7 +205,6 @@ class PlaintextConsumerTest extends BaseConsumerTest {
consumer0.subscribe(List("otherTopic").asJava, listener)
consumer0.poll(0)

assertEquals(0, committedPosition)
assertTrue(commitCompleted)
}

Expand Down