MINOR: remove duplicate map in StoreChangelogReader#5143
Merged
mjsax merged 1 commit intoapache:trunkfrom Jun 8, 2018
Merged
Conversation
Member
Author
|
Call for review @ConcurrencyPractitioner @bbejeck @vvcephei |
Contributor
|
retest this please |
guozhangwang
approved these changes
Jun 6, 2018
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM assuming the jenkins test passed.
Need to cherry-pick to 2.0
vvcephei
approved these changes
Jun 6, 2018
Member
Author
|
Retest this please |
bbejeck
approved these changes
Jun 7, 2018
Member
Author
|
Retest this please |
Member
Author
|
Test failures are unrelated... I try one last time... retest this please |
mjsax
added a commit
that referenced
this pull request
Jun 8, 2018
Reviewers: Guozhang Wang <guozhang@confluent.io>, John Roesler <john@confluent.io>, Bill Bejeck <bill@confluent.io>
Member
Author
|
Merged to |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Reviewers: Guozhang Wang <guozhang@confluent.io>, John Roesler <john@confluent.io>, Bill Bejeck <bill@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5013. The end offset for each partition is already maintained correctly in
endOffsetswithininitialize(); thus, the introducedupdatedEndOffsetsis redundant -- we missed this during review. Thanks to @guozhangwang for pointing out.Committer Checklist (excluded from commit message)