MINOR: Use KafkaConsumer in GetOffsetShell#5220
Merged
ijuma merged 5 commits intoapache:trunkfrom Jun 14, 2018
Merged
Conversation
Contributor
There was a problem hiding this comment.
Should the above two lines be removed?
This does the minimal amount of work so that the tool relies on public non-deprecated APIs (i.e. so that it doesn't rely on old clients code). Additional improvements have been proposed via KIP-308. There are a few other PRs that touch this class with overlapping goals: - apache#2891 - apache#3051 - apache#3320 One of them remains relevant in the context of KIP-308, but the others are not. I included the authors of the 3 PRs as co-authors. Co-authored-by: Arseniy Tashoyan <tashoyan@gmail.com> Co-authored-by: Vahid Hashemian <vahidhashemian@us.ibm.com> Co-authored-by: Mohammed Amine GARMES Co-authored-by: Ismael Juma <ismael@juma.me.uk>
ijuma
force-pushed
the
use-java-consumer-in-offset-shell
branch
from
53bb908 to
aaa6c5c
Compare
omkreddy
reviewed
Jun 14, 2018
| if(args.length == 0) | ||
|
|
||
| if (args.length == 0) | ||
| CommandLineUtils.printUsageAndDie(parser, "An interactive shell for getting consumer offsets.") |
Contributor
There was a problem hiding this comment.
nit: we can update existing usage description
"An interactive shell for getting TOPIC offsets."
| System.err.println(("Error: no valid topic metadata for topic: %s, " + " probably the topic does not exist, run ").format(topic) + | ||
| "kafka-list-topic.sh to verify") | ||
| Exit.exit(1) | ||
| val partitionIdsRequested = options.valueOf(partitionOpt).split(",").map(_.toInt).toSet |
Contributor
There was a problem hiding this comment.
need to handle empty string. partitionOpt default value is empty string
|
|
||
| val config = new Properties | ||
| config.setProperty(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, brokerList) | ||
| config.setProperty(ConsumerConfig.CLIENT_ID_CONFIG, clientId) |
Contributor
There was a problem hiding this comment.
missing consumer deserializer props
Member
Author
|
Thanks for the review @omkreddy. Sorry, I should have mentioned that this was still WIP and I had not tested it yet. :) |
rajinisivaram
approved these changes
Jun 14, 2018
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@ijuma Thanks for the PR, LGTM
Member
Author
|
JUnit test failure is unrelated and get_offset_shell system test passed: https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder/1788/console Merging to trunk and 2.0. |
ijuma
added a commit
that referenced
this pull request
Jun 14, 2018
This does the minimal amount of work so that the tool relies on public non-deprecated APIs (i.e. it no longer relies on Scala clients code). Additional improvements (not included here) have been proposed via KIP-308. There are a few other PRs that touch this class with overlapping goals: - #2891 - #3051 - #3320 One of them remains relevant in the context of KIP-308, but the others have been superseded. I included the authors of the 3 PRs as co-authors. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Vahid Hashemian <vahidhashemian@us.ibm.com>, Manikumar Reddy <manikumar.reddy@gmail.com> Co-authored-by: Arseniy Tashoyan <tashoyan@gmail.com> Co-authored-by: Vahid Hashemian <vahidhashemian@us.ibm.com> Co-authored-by: Mohammed Amine GARMES Co-authored-by: Ismael Juma <ismael@juma.me.uk>
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
This does the minimal amount of work so that the tool relies on public non-deprecated APIs (i.e. it no longer relies on Scala clients code). Additional improvements (not included here) have been proposed via KIP-308. There are a few other PRs that touch this class with overlapping goals: - apache#2891 - apache#3051 - apache#3320 One of them remains relevant in the context of KIP-308, but the others have been superseded. I included the authors of the 3 PRs as co-authors. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Vahid Hashemian <vahidhashemian@us.ibm.com>, Manikumar Reddy <manikumar.reddy@gmail.com> Co-authored-by: Arseniy Tashoyan <tashoyan@gmail.com> Co-authored-by: Vahid Hashemian <vahidhashemian@us.ibm.com> Co-authored-by: Mohammed Amine GARMES Co-authored-by: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the minimal amount of work so that the tool
relies on public non-deprecated APIs (i.e. it no longer
relies on Scala clients code).
Additional improvements (not included here) have
been proposed via KIP-308.
There are a few other PRs that touch this class with
overlapping goals:
One of them remains relevant in the context of KIP-308, but
the others have been superseded. I included the authors of
the 3 PRs as co-authors.
Co-authored-by: Arseniy Tashoyan tashoyan@gmail.com
Co-authored-by: Vahid Hashemian vahidhashemian@us.ibm.com
Co-authored-by: Mohammed Amine GARMES
Co-authored-by: Ismael Juma ismael@juma.me.uk
Committer Checklist (excluded from commit message)