KAFKA-7082: Concurrent create topics may throw NodeExistsException#5259
Merged
ijuma merged 2 commits intoapache:trunkfrom Jun 21, 2018
Merged
KAFKA-7082: Concurrent create topics may throw NodeExistsException#5259ijuma merged 2 commits intoapache:trunkfrom
ijuma merged 2 commits intoapache:trunkfrom
Conversation
Without this change, we can throw a `NodeExistsException`. This minimal change makes the behaviour match `ZkUtils`. Added a concurrent test that failed without this change.
ijuma
changed the title
Contributor
|
LGTM |
Member
Author
|
JDK 10 Jenkins job passed, the 2 failures in the JDK 8 job are unrelated. |
ijuma
added a commit
that referenced
this pull request
Jun 21, 2018
…5259) This is an unexpected exception so `UnknownServerException` is thrown back to the client. This is a minimal change to make the behaviour match `ZkUtils`. This is better, but one could argue that it's not perfect. A more sophisticated approach can be tackled separately. Added a concurrent test that fails without this change. Reviewers: Jun Rao <junrao@gmail.com>
Member
Author
|
Merged to trunk, 2.0 and 1.1. |
ijuma
added a commit
that referenced
this pull request
Jun 21, 2018
…5259) This is an unexpected exception so `UnknownServerException` is thrown back to the client. This is a minimal change to make the behaviour match `ZkUtils`. This is better, but one could argue that it's not perfect. A more sophisticated approach can be tackled separately. Added a concurrent test that fails without this change. Reviewers: Jun Rao <junrao@gmail.com>
tedyu
reviewed
Jun 23, 2018
| def createOrSet(configData: Array[Byte]): Unit = { | ||
| val path = ConfigEntityZNode.path(rootEntityType, sanitizedEntityName) | ||
| createRecursive(path, ConfigEntityZNode.encode(config)) | ||
| try createRecursive(path, ConfigEntityZNode.encode(config)) |
Contributor
There was a problem hiding this comment.
The second parameter can be replaced with configData, right ?
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…pache#5259) This is an unexpected exception so `UnknownServerException` is thrown back to the client. This is a minimal change to make the behaviour match `ZkUtils`. This is better, but one could argue that it's not perfect. A more sophisticated approach can be tackled separately. Added a concurrent test that fails without this change. Reviewers: Jun Rao <junrao@gmail.com>
allenxwang
pushed a commit
to allenxwang/kafka
that referenced
this pull request
Aug 24, 2018
…:1.1.1-sync to 1.1-nflx * commit '9611672e287c1a7933a78590e3f381da2ae7d136': (57 commits) MINOR: increase dev version from 1.1.1-SNAPSHOT to 1.1.2-SNAPSHOT (apache#5409) MINOR: Add thread dumps if broker node cannot be stopped (apache#5373) MINOR: update release.py MINOR: fix upgrade docs for Streams (apache#5392) MINOR: improve docs version numbers (apache#5372) Update version on the branch to 1.1.2-SNAPSHOT KAFKA-6292; Improve FileLogInputStream batch position checks to avoid type overflow (apache#4928) HOTFIX: Fix checkstyle errors in MetricsTest (apache#5345) KAFKA-7136: Avoid deadlocks in synchronized metrics reporters (apache#5341) MINOR: Close timing window in SimpleAclAuthorizer startup (apache#5318) MINOR: Use kill_java_processes when killing ConsoleConsumer in system tests (apache#5297) KAFKA-7104: More consistent leader's state in fetch response (apache#5305) Revert "MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258)" MINOR: Avoid coarse lock in Pool#getAndMaybePut (apache#5258) MINOR: bugfix streams total metrics (apache#5277) KAFKA-7082: Concurrent create topics may throw NodeExistsException (apache#5259) MINOR: Upgrade to Gradle 4.8.1 KAFKA-7012: Don't process SSL channels without data to process (apache#5237) KAFKA-7058: Comparing schema default values using Objects#deepEquals() KAFKA-7047: Added SimpleHeaderConverter to plugin isolation whitelist ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an unexpected exception so
UnknownServerExceptionis thrown back to the client.
This is a minimal change to make the behaviour match
ZkUtils.This is better, but one could argue that it's not perfect. A more
sophisticated approach can be tackled separately.
Added a concurrent test that fails without this change.
Committer Checklist (excluded from commit message)