KAFKA-6944: Add system tests testing the new throttling behavior using older clients/brokers#5294
Closed
jonlee2 wants to merge 2 commits intoapache:trunkfrom
jonlee2:kafka-6944
Closed
KAFKA-6944: Add system tests testing the new throttling behavior using older clients/brokers#5294jonlee2 wants to merge 2 commits intoapache:trunkfrom jonlee2:kafka-6944
jonlee2 wants to merge 2 commits intoapache:trunkfrom
jonlee2:kafka-6944
Conversation
…g older clients/brokers
Contributor
Author
|
@lindong28 Can you review? Thank you. |
lindong28
changed the title
lindong28
reviewed
Jun 27, 2018
Member
lindong28
left a comment
lindong28
left a comment
There was a problem hiding this comment.
Thanks for the patch. Looks good overall.
| @matrix(quota_type=[QuotaConfig.CLIENT_ID, QuotaConfig.USER, QuotaConfig.USER_CLIENT], override_quota=[True, False]) | ||
| @parametrize(quota_type=QuotaConfig.CLIENT_ID, consumer_num=2) | ||
| def test_quota(self, quota_type, override_quota=True, producer_num=1, consumer_num=1): | ||
| @parametrize(quota_type=QuotaConfig.CLIENT_ID, old_throttling_for_broker=True) |
Member
There was a problem hiding this comment.
Can you replace old_throttling_for_broker with old_broker_throttling_behavior? Same for old_throttling_for_client.
Fix parameter
Member
|
Thanks for the patch. Merged to trunk. |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
…g older clients/brokers Added two additional test cases to quota_test.py, which run between brokers and clients with different throttling behaviors. More specifically, 1. clients with new throttling behavior (i.e., post-KIP-219) and brokers with old throttling behavior (i.e., pre-KIP-219) 2. clients with old throttling behavior and brokers with new throttling behavior Author: Jon Lee <jonlee@linkedin.com> Author: Dong Lin <lindong28@gmail.com> Reviewers: Dong Lin <lindong28@gmail.com> Closes apache#5294 from jonlee2/kafka-6944
lindong28
pushed a commit
that referenced
this pull request
Jul 21, 2018
…g older clients/brokers Added two additional test cases to quota_test.py, which run between brokers and clients with different throttling behaviors. More specifically, 1. clients with new throttling behavior (i.e., post-KIP-219) and brokers with old throttling behavior (i.e., pre-KIP-219) 2. clients with old throttling behavior and brokers with new throttling behavior Author: Jon Lee <jonlee@linkedin.com> Author: Dong Lin <lindong28@gmail.com> Reviewers: Dong Lin <lindong28@gmail.com> Closes #5294 from jonlee2/kafka-6944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two additional test cases to quota_test.py, which run between brokers and clients with different throttling behaviors. More specifically,
Committer Checklist (excluded from commit message)