KAFKA-2605: Replace 'catch: Throwable' clauses with 'NonFatal'#531
Closed
jinxing64 wants to merge 1 commit intoapache:0.8.2from
jinxing64:0.8.2
Closed
KAFKA-2605: Replace 'catch: Throwable' clauses with 'NonFatal'#531jinxing64 wants to merge 1 commit intoapache:0.8.2from jinxing64:0.8.2
jinxing64 wants to merge 1 commit intoapache:0.8.2from
jinxing64:0.8.2
Conversation
Merged
3 tasks
gwenshap
referenced
this pull request
in confluentinc/kafka
Jul 21, 2019
…re (#531) We wish to return a yellow build on a test failure, but wish to fail the build completely when the gradle executors do not finish cleanly. This change will achieve that. (cherry picked from commit 334acf48d40e6a3c627cb71990fa91e1616e4921) -- This also changes max number of forks to 4, to improve build stability
gwenshap
referenced
this pull request
in confluentinc/kafka
Jul 21, 2019
…re (#531) We wish to return a yellow build on a test failure, but wish to fail the build completely when the gradle executors do not finish cleanly. This change will achieve that. (cherry picked from commit 334acf48d40e6a3c627cb71990fa91e1616e4921)
gwenshap
referenced
this pull request
in confluentinc/kafka
Jul 21, 2019
…re (#531) (#215) We wish to return a yellow build on a test failure, but wish to fail the build completely when the gradle executors do not finish cleanly. This change will achieve that. (cherry picked from commit 334acf48d40e6a3c627cb71990fa91e1616e4921) -- This also changes max number of forks to 4, to improve build stability
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Mar 24, 2026
* feat(inkless): implement InitDisklessLog Controller API Persist disklessStartOffset and producer states into KRaft metadata. Only the leader is allowed to call InitDisklessLog. New fields are also persisted in the KRaft snapshots through PartitionRegistration. To avoid conflicts with upstream changes to the metadata records, new metadata fields are written directly in the unknown tagged fields of PartitionRecord and PartitionChangeRecord. (cherry picked from commit 00701557d1790b8ab74d17eb2ae95d7928f72b77) # Conflicts: # metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Mar 24, 2026
* feat(inkless): implement InitDisklessLog Controller API Persist disklessStartOffset and producer states into KRaft metadata. Only the leader is allowed to call InitDisklessLog. New fields are also persisted in the KRaft snapshots through PartitionRegistration. To avoid conflicts with upstream changes to the metadata records, new metadata fields are written directly in the unknown tagged fields of PartitionRecord and PartitionChangeRecord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'catch: Throwable' will catch VirtualMachineError, ThreadDeath, InterruptedException, LinkageError, ControlThrowable, NotImplementedError; we don't want to catch those kind of error