Skip to content

MINOR: Change "no such session ID" log to debug#5316

Merged
ijuma merged 3 commits intoapache:trunkfrom
cmccabe:fetch_session_log
Jul 21, 2018
Merged

MINOR: Change "no such session ID" log to debug#5316
ijuma merged 3 commits intoapache:trunkfrom
cmccabe:fetch_session_log

Conversation

@cmccabe
Copy link
Copy Markdown
Contributor

@cmccabe cmccabe commented Jul 1, 2018 •
edited
Loading

The metric will give us good information about the number of evictions per second, so we don't need the INFO log.

ijuma
ijuma approved these changes Jul 1, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ijuma
ijuma reviewed Jul 2, 2018
View reviewed changes
Comment thread core/src/main/scala/kafka/server/FetchSession.scala Outdated
Copy link
Copy Markdown
Member

@ijuma ijuma Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we clarify this log message a bit? What is a "error FetchContext"?

Copy link
Copy Markdown
Contributor Author

@cmccabe cmccabe Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error fetch context is a type of FetchSessionContext which always sends back an error code.

However, it's probably better just to print out a message about a session error here, since the ErrorFetchContext is an implementation detail.

@cmccabe cmccabe force-pushed the fetch_session_log branch from 01d91e2 to f8a066e Compare July 19, 2018 17:04
ijuma
ijuma approved these changes Jul 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmccabe
Copy link
Copy Markdown
Contributor Author

cmccabe commented Jul 20, 2018

retest this please

1 similar comment
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 20, 2018

retest this please

@ijuma ijuma force-pushed the fetch_session_log branch from d9b5bce to 7bb42be Compare July 21, 2018 03:49
@ijuma ijuma force-pushed the fetch_session_log branch from 7bb42be to 30d7cc9 Compare July 21, 2018 08:27
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 21, 2018

Merging to trunk and 2.0 after pushing some style fixes.

@ijuma ijuma merged commit b9b70c9 into apache:trunk Jul 21, 2018
ijuma pushed a commit that referenced this pull request Jul 21, 2018
@cmccabe @ijuma
MINOR: Change "no such session ID" log to debug (#5316)
dca4304 
Improve the log messages while at it and fix some code style issues.

Reviewers: Ismael Juma <ismael@juma.me.uk>
@cmccabe cmccabe deleted the fetch_session_log branch May 20, 2019 18:55
@rmatte01
Copy link
Copy Markdown

rmatte01 commented Oct 10, 2019

@cmccabe , We are seeing this following messages (a lot of them).

[kafka-request-handler-3] INFO (Logging.scala:66) - Created a new error FetchContext for session id 1453881506: no such session ID found.

What does this mean? I don't see any other error code from FetchSessionContext as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmccabe @ijuma @rmatte01