KAFKA-4041: Update ZooKeeper to 3.4.13#5376
Conversation
This includes a fix for ZOOKEEPER-2184, which fixes KAFKA-4041.
ewencp
left a comment
ewencp
left a comment
There was a problem hiding this comment.
LGTM. Any reason not to include KAFKA-4041 in the commit title since that's the primary reason for doing this?
ijuma
changed the title
|
@ewencp Updated the title. |
|
@ijuma Hmm, couple of test failures on JDK8 run look like they might actually be related rather than flakes -- change in behavior for re-resolving may be affecting them. |
|
@ewencp Yes indeed. The changes should only affect tests ( |
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@ijuma Thanks for the PR, LGTM. I think the test failures in the last run are not related to this change.
|
Failures look unrelated. Will run the tests again, just in case. |
|
Retest this please |
|
There was 1 Streams failure in one of the jobs and the other was also running Streams tests when the node was taken offline. |
|
retest this please |
|
One of the jobs passed, the other had a Streams failure due to a ZK timeout. The timeout is just 8 seconds, but we have a separate PR that is changing the code to use the AdminClient instead. Merging to trunk and 2.0. |
This includes a fix for ZOOKEEPER-2184 (Zookeeper Client should re-resolve hosts when connection attempts fail), which fixes KAFKA-4041. Updated a couple of tests as unresolvable addresses are now retried until the connection timeout. Cleaned up tests a little. Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
This includes a fix for ZOOKEEPER-2184 (Zookeeper Client should re-resolve hosts when connection attempts fail), which fixes KAFKA-4041. Updated a couple of tests as unresolvable addresses are now retried until the connection timeout. Cleaned up tests a little. Reviewers: Ewen Cheslack-Postava <ewen@confluent.io>, Rajini Sivaram <rajinisivaram@googlemail.com>
3 participants
This includes a fix for ZOOKEEPER-2184 (Zookeeper Client
should re-resolve hosts when connection attempts fail), which
fixes KAFKA-4041.
Updated a couple of tests as unresolvable addresses are now
retried until the connection timeout. Cleaned up tests a little.
Committer Checklist (excluded from commit message)