Skip to content

KAFKA-7177: Update 2.0 documentation to reflect changed quota behaviors by KIP-219#5384

Closed
jonlee2 wants to merge 1 commit intoapache:trunkfrom
jonlee2:KAFKA-7177
Closed

KAFKA-7177: Update 2.0 documentation to reflect changed quota behaviors by KIP-219#5384
jonlee2 wants to merge 1 commit intoapache:trunkfrom
jonlee2:KAFKA-7177

Conversation

@jonlee2
Copy link
Copy Markdown
Contributor

@jonlee2 jonlee2 commented Jul 18, 2018

Updated the 2.0 document for changed quota behaviors.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jonlee2
Copy link
Copy Markdown
Contributor Author

jonlee2 commented Jul 18, 2018

@lindong28 Can you review? Thanks.

Comment thread docs/design.html Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should change or remove the sentence that says This approach keeps the quota violation transparent to clients (outside of client-side metrics). This also keeps them from having to implement any special backoff and retry behavior which can get tricky. In fact, bad client behavior (retry without backoff) can exacerbate the very problem quotas are trying to solve.

@lindong28 lindong28 changed the title KAFKA-7177: Update 2.0 documentation to reflect changed quota behavio… KAFKA-7177: Update 2.0 documentation to reflect changed quota behaviors by KIP-219 Jul 18, 2018
@lindong28 lindong28 self-assigned this Jul 18, 2018
@jonlee2
Copy link
Copy Markdown
Contributor Author

jonlee2 commented Jul 18, 2018

Remove those sentences. @lindong28 Can you take a look again? Thanks.

@lindong28
Copy link
Copy Markdown
Member

@jonlee2 LGTM in terms of its content. I think client layer should probably just be client.

@ijuma You have much better english writing than me. Since this touches the design doc that user reads, would you have time to take a look?

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 19, 2018

Thanks for the PR. I think it would be useful to explain the reasoning of the approach a little. For example, this still handles badly behaved clients by relying on socket buffer back pressure.

@jonlee2
Copy link
Copy Markdown
Contributor Author

jonlee2 commented Jul 19, 2018

Updated the text as suggested. @lindong28 @ijuma Can you take another look? Thanks.

@lindong28
Copy link
Copy Markdown
Member

Thanks for update. LGTM. @ijuma may have better ideas of writing.

@asfgit
Copy link
Copy Markdown

asfgit commented Jul 20, 2018

FAILURE
9189 tests run, 5 skipped, 1 failed.
--none--

@lindong28
Copy link
Copy Markdown
Member

I just merged it to trunk so that we can use the design doc for 2.0 release. We can have minor followup patch to improve the doc if needed.

@lindong28 lindong28 closed this in f9cdadf Jul 21, 2018
lindong28 pushed a commit that referenced this pull request Jul 21, 2018
…rs by KIP-219

Updated the 2.0 document for changed quota behaviors.

Author: Jon Lee <jonlee@linkedin.com>

Reviewers: Ismael Juma <ismael@juma.me.uk>, Dong Lin <lindong28@gmail.com>

Closes #5384 from jonlee2/KAFKA-7177
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 22, 2018

Seems fine to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants