KAFKA-7177: Update 2.0 documentation to reflect changed quota behaviors by KIP-219#5384
KAFKA-7177: Update 2.0 documentation to reflect changed quota behaviors by KIP-219#5384jonlee2 wants to merge 1 commit intoapache:trunkfrom jonlee2:KAFKA-7177
Conversation
|
@lindong28 Can you review? Thanks. |
There was a problem hiding this comment.
We probably should change or remove the sentence that says This approach keeps the quota violation transparent to clients (outside of client-side metrics). This also keeps them from having to implement any special backoff and retry behavior which can get tricky. In fact, bad client behavior (retry without backoff) can exacerbate the very problem quotas are trying to solve.
|
Remove those sentences. @lindong28 Can you take a look again? Thanks. |
|
Thanks for the PR. I think it would be useful to explain the reasoning of the approach a little. For example, this still handles badly behaved clients by relying on socket buffer back pressure. |
|
Updated the text as suggested. @lindong28 @ijuma Can you take another look? Thanks. |
|
Thanks for update. LGTM. @ijuma may have better ideas of writing. |
|
FAILURE |
|
I just merged it to trunk so that we can use the design doc for 2.0 release. We can have minor followup patch to improve the doc if needed. |
…rs by KIP-219 Updated the 2.0 document for changed quota behaviors. Author: Jon Lee <jonlee@linkedin.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Dong Lin <lindong28@gmail.com> Closes #5384 from jonlee2/KAFKA-7177
|
Seems fine to me, thanks. |
Updated the 2.0 document for changed quota behaviors.
Committer Checklist (excluded from commit message)