KAFKA-7180: Fixing the flaky test testHWCheckpointWithFailuresSingleLogSegment#5387
Closed
gitlw wants to merge 1 commit intoapache:trunkfrom
gitlw:fixing_flacky_logrecevorytest
Closed
KAFKA-7180: Fixing the flaky test testHWCheckpointWithFailuresSingleLogSegment#5387gitlw wants to merge 1 commit intoapache:trunkfrom gitlw:fixing_flacky_logrecevorytest
gitlw wants to merge 1 commit intoapache:trunkfrom
gitlw:fixing_flacky_logrecevorytest
Conversation
…as joined the ISR before shutting down server2
Contributor
|
retest this please |
Member
|
@gitlw Nice catch. Thanks for fixing the test. LGTM. |
lindong28
approved these changes
Jul 30, 2018
lindong28
pushed a commit
that referenced
this pull request
Jul 30, 2018
…ogSegment By waiting until server1 has joined the ISR before shutting down server2 Rerun the test method many times after the code change, and there is no flakiness any more. Author: Lucas Wang <luwang@linkedin.com> Reviewers: Mayuresh Gharat <gharatmayuresh15@gmail.com>, Dong Lin <lindong28@gmail.com> Closes #5387 from gitlw/fixing_flacky_logrecevorytest (cherry picked from commit 96bc0b8) Signed-off-by: Dong Lin <lindong28@gmail.com>
Member
|
Merged to trunk and the 2.0 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By waiting until server1 has joined the ISR before shutting down server2
Rerun the test method many times after the code change, and there is no flakiness any more.
Committer Checklist (excluded from commit message)