Skip to content

MINOR: update DEFAULT_FIX_VERSION to 1.1.2 in kafka-merge-pr.py#5413

Closed
lindong28 wants to merge 1 commit intoapache:1.1from
lindong28:update-version
Closed

MINOR: update DEFAULT_FIX_VERSION to 1.1.2 in kafka-merge-pr.py#5413
lindong28 wants to merge 1 commit intoapache:1.1from
lindong28:update-version

Conversation

@lindong28
Copy link
Copy Markdown
Member

@lindong28 lindong28 commented Jul 22, 2018

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 22, 2018

Thanks for the PR. Not sure if we need this, I think the workflow should be to use the merge script from trunk generally.

@lindong28
Copy link
Copy Markdown
Member Author

@ijuma You are right. Thanks for pointing this out. Now looking at the kafka-merge-pr.py, it shows that the DEFAULT_FIX_VERSION is only needed for the trunk branch, which in turn suggests that we do not need to change DEFAULT_FIX_VERSION for bug fix release. I slightly modified the release process to clarify this.

See https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=34840886&selectedPageVersions=140&selectedPageVersions=141.

@lindong28 lindong28 closed this Jul 22, 2018
@lindong28
Copy link
Copy Markdown
Member Author

Thanks for your review @mjsax. I closed the PR since it seems not necessary for non-trunk branch.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Jul 22, 2018

Thanks for updating the release process instructions.

@lindong28 lindong28 deleted the update-version branch July 22, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants