KAFKA-7193: Use ZooKeeper IP address in streams tests to avoid timeouts#5414
Merged
rajinisivaram merged 2 commits intoapache:trunkfrom Jul 23, 2018
Merged
Conversation
ijuma
approved these changes
Jul 23, 2018
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for diagnosing this, LGTM.
Contributor
Author
|
@ijuma Thanks for the review, will merge after builds complete. |
mjsax
approved these changes
Jul 23, 2018
Contributor
Author
|
retest this please |
Contributor
Author
|
Test failures look unrelated, so merging to trunk and 2.0. |
rajinisivaram
added a commit
that referenced
this pull request
Jul 23, 2018
…ts (#5414) ZooKeeper client from version 3.4.13 doesn't handle connections to localhost very well. If ZooKeeper is started on 127.0.0.1 on a machine that has both ipv4 and ipv6 and a client is created using localhost rather than the IP address in the connection string, ZooKeeper client attempts to connect to ipv4 or ipv6 randomly with a fixed one second backoff if connection fails. Use 127.0.0.1 instead of localhost in streams tests to avoid intermittent test failures due to ZK client connection timeouts if ipv6 is chosen in consecutive address selections. Also add note to upgrade docs for 2.0.0. Reviewers: Ismael Juma <github@juma.me.uk>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZooKeeper client from version 3.4.13 doesn't handle connections to
localhostvery well. If ZooKeeper is started on 127.0.0.1 on a machine that has both ipv4 and ipv6 and a client is created usinglocalhostrather than the IP address in the connection string, ZooKeeper client attempts to connect to ipv4 or ipv6 randomly with a fixed one second backoff if connection fails. Use127.0.0.1instead oflocalhostin streams tests to avoid intermittent test failures due to ZK client connection timeouts if ipv6 is chosen in consecutive address selections. Also add note to upgrade docs for 2.0.0.Committer Checklist (excluded from commit message)