MINOR: Caching layer should forward record timestamp#5423
Merged
mjsax merged 2 commits intoapache:trunkfrom Jul 26, 2018
Merged
MINOR: Caching layer should forward record timestamp#5423mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
Member
Author
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Add a unit test for this case?
Member
Author
|
@guozhangwang Done. Extended existing unit test |
mjsax
commented
Jul 26, 2018
Member
Author
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Contains couple of Java8 rewrite and code cleanup (tried to mark accordingly with comments)
| }; | ||
| reducer = (value1, value2) -> value1 + ":" + value2; | ||
| initializer = () -> 0; | ||
| aggregator = (aggKey, value, aggregate) -> aggregate + value.length(); |
| return KStreamAggregationIntegrationTest.compare(o1, o2); | ||
| } | ||
| }); | ||
| Collections.sort(results, KStreamAggregationIntegrationTest::compare); |
| return keyComparison == 0 ? o1.value.compareTo(o2.value) : keyComparison; | ||
| } | ||
| }; | ||
| Comparator.comparing((KeyValue<Windowed<String>, String> o) -> o.key.key()).thenComparing(o -> o.value); |
| return KStreamAggregationIntegrationTest.compare(o1, o2); | ||
| } | ||
| }); | ||
| Collections.sort(results, KStreamAggregationIntegrationTest::compare); |
| new IntegerDeserializer(), | ||
| String.class, | ||
| 15, | ||
| true); |
| } | ||
| .foreach((key, value) -> { | ||
| results.put(key, value); | ||
| latch.countDown(); |
| accumData.addAll(readData); | ||
| return accumData.size() >= expectedNumRecords; | ||
| } | ||
| final TestCondition valuesRead = () -> { |
| readRecords(topic, consumer, waitTime, expectedNumRecords); | ||
| accumData.addAll(readData); | ||
| return accumData.size() >= expectedNumRecords; | ||
| } |
| accumData.addAll(readData); | ||
| return accumData.size() >= expectedNumRecords; | ||
| } | ||
| final TestCondition valuesRead = () -> { |
| if (!Request.isValidBrokerId(metadataPartitionState.basePartitionState.leader)) { | ||
| return false; | ||
| } | ||
| TestUtils.waitForCondition(() -> { |
guozhangwang
approved these changes
Jul 26, 2018
mjsax
added a commit
that referenced
this pull request
Jul 26, 2018
Reviewer: Guozhang Wang <guozhang@confluent.io>
mjsax
added a commit
to mjsax/kafka
that referenced
this pull request
Jul 26, 2018
Reviewer: Guozhang Wang <guozhang@confluent.io>
3 tasks
Member
Author
|
Merged to |
guozhangwang
pushed a commit
that referenced
this pull request
Jul 26, 2018
2 tasks
mjsax
added a commit
that referenced
this pull request
Aug 1, 2018
mjsax
added a commit
that referenced
this pull request
Aug 1, 2018
mjsax
added a commit
that referenced
this pull request
Aug 1, 2018
mjsax
added a commit
that referenced
this pull request
Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)