KAFKA-7253 The connector type responded by worker is always null when…#5470
KAFKA-7253 The connector type responded by worker is always null when…#5470hachikuji merged 1 commit intoapache:trunkfrom
Conversation
|
ReassignPartitionsClusterTest pass locally |
chia7712
force-pushed
the
KAFKA-7253
branch
2 times, most recently
from
deedafa to
3b347a3
Compare
|
There already is a related test - DistributedHerderTest#testCreateConnector. However, ConnectorInfo#equals doesn't compare the connector type so DistributedHerderTest#testCreateConnector doesn't discover the bug. |
|
@hachikuji Could you please take a look if you have free cycle? thanks! |
|
Ping for reviews since this bug is related to public APIs of connector |
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Left a minor comment, but otherwise LGTM.
There was a problem hiding this comment.
We should update hashCode as well?
There was a problem hiding this comment.
@hachikuji You are right. Will update the PR asap
… creating connector
|
The failures appear to be unrelated. I will go ahead and merge. Thanks for the patch! |
Thanks for the review! |
…connector (#5470) The null map returned from the current snapshot causes the null type in response. The connector class name can be taken from the config of request instead since we require the config should contain the connector class name. Reviewers: Jason Gustafson <jason@confluent.io>
…connector (#5470) The null map returned from the current snapshot causes the null type in response. The connector class name can be taken from the config of request instead since we require the config should contain the connector class name. Reviewers: Jason Gustafson <jason@confluent.io>
|
@hachikuji Is this PR backported to 1.x? This PR fix a bug about public APIs (I assume connector restful APIs is a part of kafka's public APIs) |
…connector (apache#5470) The null map returned from the current snapshot causes the null type in response. The connector class name can be taken from the config of request instead since we require the config should contain the connector class name. Reviewers: Jason Gustafson <jason@confluent.io>
2 participants
Committer Checklist (excluded from commit message)