KAFKA-7369; Handle retriable errors in AdminClient list groups API#5595
Merged
hachikuji merged 3 commits intoapache:trunkfrom Sep 1, 2018
Merged
KAFKA-7369; Handle retriable errors in AdminClient list groups API#5595hachikuji merged 3 commits intoapache:trunkfrom
hachikuji merged 3 commits intoapache:trunkfrom
Conversation
3 tasks
Contributor
|
LGTM |
guozhangwang
approved these changes
Aug 31, 2018
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
LGTM
@hachikuji this is not in the scope of this PR, but looking into the handleResponse() functions lots of them seem to not follow the throw-and-let-it-handled-by-Call patten, e.g.
DescribeTopicsResult#handleResponse
CreateAclsResult#handleResponse
Should we make a pass over these and make sure they are all covered in a separate PR?
Contributor
Author
|
@guozhangwang Yeah, good call. I'll make a pass and create JIRAs if they don't already exist. |
hachikuji
added a commit
that referenced
this pull request
Sep 1, 2018
…5595) We should retry when possible if ListGroups fails due to a retriable error (e.g. coordinator loading). Reviewers: Colin Patrick McCabe <colin@cmccabe.xyz>, Guozhang Wang <wangguoz@gmail.com>
Contributor
|
@hachikuji recently I raised a similar PR #5578 to handle retraible errors in consumer group related API. Pls take a look. |
3 tasks
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…pache#5595) We should retry when possible if ListGroups fails due to a retriable error (e.g. coordinator loading). Reviewers: Colin Patrick McCabe <colin@cmccabe.xyz>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should retry when possible if ListGroups fails due to a retriable error (e.g. coordinator loading).
Committer Checklist (excluded from commit message)