KAFKA-5462: Add configuration to build custom SSL principal name (KIP-371)#5684
KAFKA-5462: Add configuration to build custom SSL principal name (KIP-371)#5684omkreddy wants to merge 2 commits intoapache:trunkfrom
Conversation
|
@rajinisivaram Please take a look, whenever you get a chance. |
|
@rajinisivaram no worries. anyhow KIP vote is not yet passed. Vote pending for one more binding vote. we can merge after 2.1 rush. |
|
@junrao @lindong28 Appreciate your review and vote for this simple KIP-371 : https://cwiki.apache.org/confluence/display/KAFKA/KIP-371%3A+Add+a+configuration+to+build+custom+SSL+principal+name) |
omkreddy
force-pushed
the
KAFKA-5462-SSL-Name
branch
from
96d766f to
28d5acb
Compare
|
@harshach @rajinisivaram KIP-371 vote has passed now. Pls take a look, when you get a chance. |
omkreddy
force-pushed
the
KAFKA-5462-SSL-Name
branch
from
28d5acb to
3ea726d
Compare
omkreddy
force-pushed
the
KAFKA-5462-SSL-Name
branch
from
3ea726d to
89cb1c2
Compare
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class SSLPrincipalMapper { |
There was a problem hiding this comment.
Nit: we are using camecased "Ssl" instead of "SSL" everywhere else, can we make this consistent.
|
Overall LGTM. Minor nit. After address I am +1. |
omkreddy
force-pushed
the
KAFKA-5462-SSL-Name
branch
from
882dd7d to
846dc65
Compare
omkreddy
force-pushed
the
KAFKA-5462-SSL-Name
branch
from
846dc65 to
90ec4e7
Compare
|
retest this please |
|
@harshach Thanks for the review. Updated the PR. |
|
java 11 failures are not related |
|
+1 |
|
@rajinisivaram I would like to merge this to trunk. let me know if any concerns. |
|
Merged to trunk. |
…-371) Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Sriharsha Chintalapani <sriharsha@apache.org> Closes apache#5684 from omkreddy/KAFKA-5462-SSL-Name
3 participants
Committer Checklist (excluded from commit message)