KAFKA-7449 Forward topic from console consumer to deserializer#5704
Merged
junrao merged 1 commit intoapache:trunkfrom Nov 29, 2018
mchataigner:deserializer
Merged
KAFKA-7449 Forward topic from console consumer to deserializer#5704junrao merged 1 commit intoapache:trunkfrom mchataigner:deserializer
junrao merged 1 commit intoapache:trunkfrom
mchataigner:deserializer
Conversation
Contributor
|
LGTM |
Member
|
LGTM. Does it need a test? ConsoleConsumerTest should be a suitable place. |
Member
|
Yes, a test would be good. |
Contributor
Author
|
Done (sorry for the delay). |
Contributor
Author
|
I don't realy understand why the build on JDK 11 with Scala 2.12 is ending in timeout. |
Some deserializer needs the topic name to be able to correctly deserialize the payload of the message. Console consumer works great with Deserializer<String> however it calls deserializer with topic set as null. This breaks the API and the topic information is available in the ConsumerRecord.
Contributor
|
Hmm not sure why the test is being skipped for the JDK 8 build, lets have Jenkins rerun the tests. |
junrao
approved these changes
Nov 29, 2018
Contributor
junrao
left a comment
junrao
left a comment
There was a problem hiding this comment.
@mchataigner : Thanks for the patch. LGTM
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Some deserializer needs the topic name to be able to correctly deserialize the payload of the message. Console consumer works great with Deserializer<String> however it calls deserializer with topic set as null. This breaks the API and the topic information is available in the ConsumerRecord. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>, Gardner Vickers <gardner@vickers.me>, Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some deserializer needs the topic name to be able to correctly deserialize the payload of the message.
Console consumer works great with Deserializer however it calls deserializer with topic set as null.
This breaks the API and the topic information is available in the ConsumerRecord.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)