KAFKA-6605 fix NPE in Flatten when optional Struct is null - backport…#5706
Closed
mihbor wants to merge 1 commit intoapache:2.0from
Closed
KAFKA-6605 fix NPE in Flatten when optional Struct is null - backport…#5706mihbor wants to merge 1 commit intoapache:2.0from
mihbor wants to merge 1 commit intoapache:2.0from
Conversation
mihbor
force-pushed
the
KAFKA-6605-2.0
branch
from
c651e27 to
96fcff6
Compare
HungUnicorn
reviewed
Jul 9, 2019
| Schema updatedSchema = schemaUpdateCache.get(schema); | ||
| if (updatedSchema == null) { | ||
| final SchemaBuilder builder = SchemaUtil.copySchemaBasics(value.schema(), SchemaBuilder.struct()); | ||
| Struct defaultValue = (Struct) value.schema().defaultValue(); |
There was a problem hiding this comment.
it looks for me that before this change, only value.schema is used instead of key.schema should also be considered, which looks not correct, or?
Contributor
There was a problem hiding this comment.
The operatingSchema(record) (line 141 in the PR) obtains the key or value schema, depending upon which transformation is used. So the new PR is a bit more clear, and I believe it is correct.
The prior code used value for the operating value, but if the Flatten$Key transformation was being used the operatingValue(...) actually returned the key, so the value variable name is a bit of a misnomer.
There was a problem hiding this comment.
Thanks for your detail explanation!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to 2.0
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)