Amend GetOffsetShell to support passing SSL properties#5772
Closed
mattjslack wants to merge 4 commits intoapache:trunkfrom
Closed
Amend GetOffsetShell to support passing SSL properties#5772mattjslack wants to merge 4 commits intoapache:trunkfrom
mattjslack wants to merge 4 commits intoapache:trunkfrom
Conversation
|
+1. LGTM |
harshach
approved these changes
Oct 20, 2018
Member
|
This is adding a CLI parameter so it needs a KIP. As it happens someone has already done that: We should get that KIP approved and the relevant PR. |
andrewchoi5
approved these changes
Feb 2, 2020
|
This PR is being marked as stale since it has not had any activity in 90 days. If you If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Member
|
This has been done in #9430, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to monitor the current offset and lag on SSL enabled Kafka clusters. This functionality has been added to other classes (e.g. ConfigCommand), but not this one. I have replicated the same syntax for the command line option.
Change has been tested by calling GetOffShell using both SSL (v1.1) and non-SSL (v0.10.2.1) clusters.
Committer Checklist (excluded from commit message)